Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] UI Specifiable Sketches #15

Closed
wants to merge 1 commit into from
Closed

Conversation

kneitinger
Copy link
Owner

@kneitinger kneitinger commented Oct 26, 2021

Status

Screenshot of nightgraph-ui with specifiable sketches
right now, this PR is just a rough hard-coding of the type of code that a macro like #[sketchlist] would generate.

Aesthetically (in both the UI and the macros) there is a bit to figure out still, but the foundation seems solid enough.

Todo

  • Add sketchlist macro. The scratch commit in this PR has it as an attribute macro, but that might be kind of clunky since it needs to apply to an item. In this case, a module is the only semi-appropriate item, and even that feels clunky since its contents are not really going to be passed through to the resulting code. A better choice might be a proc macro function-like macro.
  • Prettier sketch selection in UI. Right now it is hard-coded radio buttons as a proof of concept. egui selectable labels might be more visually appealing, but a drop down might make the most sense.
  • Adding a sketch to the sketch list (in whatever form it takes) should be a one line operation (regardless of egui or clap).

@kneitinger
Copy link
Owner Author

Also todo: that first commit definitely should not have passed lol.

Incorporate unused, etc denies into #1

@kneitinger
Copy link
Owner Author

Closed in favor of #23

@kneitinger kneitinger closed this Nov 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant