Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remote build private repo support #2580

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

lkingland
Copy link
Member

@lkingland lkingland commented Nov 19, 2024

  • 🎁 allow remote builds to access private repositories

By setting the DOCKER_CONFIG prior to the "buildah bud" command being, it should pick up authentication necessary for accessing private repositories.

/kind enhancement

Copy link

knative-prow bot commented Nov 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lkingland

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 19, 2024
Copy link

codecov bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.40%. Comparing base (bf9a70a) to head (556927f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2580      +/-   ##
==========================================
+ Coverage   64.12%   65.40%   +1.28%     
==========================================
  Files         130      130              
  Lines       15485    15494       +9     
==========================================
+ Hits         9929    10134     +205     
+ Misses       4619     4385     -234     
- Partials      937      975      +38     
Flag Coverage Δ
e2e-test 35.87% <0.00%> (-0.03%) ⬇️
e2e-test-oncluster 32.89% <100.00%> (+0.07%) ⬆️
e2e-test-oncluster-runtime 28.68% <100.00%> (?)
e2e-test-runtime-go 26.43% <0.00%> (?)
e2e-test-runtime-node 25.83% <0.00%> (?)
e2e-test-runtime-python 25.83% <0.00%> (?)
e2e-test-runtime-quarkus 25.98% <0.00%> (?)
e2e-test-runtime-rust 24.97% <0.00%> (?)
e2e-test-runtime-springboot 25.01% <0.00%> (?)
e2e-test-runtime-typescript 25.94% <0.00%> (?)
integration-tests 51.96% <100.00%> (+2.31%) ⬆️
unit-tests 50.89% <100.00%> (?)
unit-tests-macos-latest ?
unit-tests-ubuntu-latest ?
unit-tests-windows-latest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@lkingland lkingland requested review from matejvasek and removed request for jrangelramos and nainaz November 19, 2024 05:24
@matejvasek
Copy link
Contributor

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Nov 19, 2024
@knative-prow knative-prow bot merged commit 2fd4982 into knative:main Nov 19, 2024
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/enhancement lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants