IntegrationSource CRD #8238
Merged
IntegrationSource CRD #8238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knative-prow
bot
added
do-not-merge/hold
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8238 +/- ##
==========================================
- Coverage 64.61% 64.58% -0.03%
==========================================
Files 362 373 +11
Lines 22226 22619 +393
==========================================
+ Hits 14361 14609 +248
- Misses 7113 7244 +131
- Partials 752 766 +14 ☔ View full report in Codecov by Sentry. |
matzew
commented
Oct 10, 2024
|
|
||
| func selectImage(source *v1alpha1.IntegrationSource) string { | ||
| if source.Spec.Timer != nil { | ||
| return "quay.io/openshift-knative/kn-connector-timer-source:1.0-SNAPSHOT" |
There was a problem hiding this comment.
@dsimansk for this to get rid of, let's see if we can get the integrations repo setup w/ image push etc.
and yes, this code will be changing too. but is first draft. I am currently more focused on having things work
pierDipi
reviewed
Oct 11, 2024
pierDipi
reviewed
Oct 11, 2024
This was referenced Oct 11, 2024
matzew
force-pushed
the
poc_integration_source
branch
from
86eca45
to
96df997
Compare
matzew
force-pushed
the
poc_integration_source
branch
5 times, most recently
from
dd6df79
to
f0bae00
Compare
matzew
commented
Oct 28, 2024
|
|
||
| func selectImage(source *v1alpha1.IntegrationSource) string { | ||
| if source.Spec.Timer != nil { | ||
| return "gcr.io/knative-nightly/timer-source:latest" |
There was a problem hiding this comment.
In a soon/future PR image will be read from config map. But for now this works
|
/test reconciler-tests |
pierDipi
reviewed
Oct 28, 2024
…lly the container source for the handling of the kamelet workloads. the logic for applying the env-vars is a bit verbose, but can be improved. Tests/lifeccyle and some other improvements are still missing. but this works. Signed-off-by: Matthias Wessendorf <[email protected]>
… to extend... Signed-off-by: Matthias Wessendorf <[email protected]>
Signed-off-by: Matthias Wessendorf <[email protected]>
Signed-off-by: Matthias Wessendorf <[email protected]>
Co-authored-by: Pierangelo Di Pilato <[email protected]>
Co-authored-by: Pierangelo Di Pilato <[email protected]>
Signed-off-by: Matthias Wessendorf <[email protected]>
Signed-off-by: Matthias Wessendorf <[email protected]>
Signed-off-by: Matthias Wessendorf <[email protected]>
Signed-off-by: Matthias Wessendorf <[email protected]>
Signed-off-by: Matthias Wessendorf <[email protected]>
Signed-off-by: Matthias Wessendorf <[email protected]>
Signed-off-by: Matthias Wessendorf <[email protected]>
Signed-off-by: Matthias Wessendorf <[email protected]>
Signed-off-by: Matthias Wessendorf <[email protected]>
matzew
force-pushed
the
poc_integration_source
branch
from
f0bae00
to
839abc5
Compare
knative-prow
bot
removed
the
do-not-merge/work-in-progress
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Signed-off-by: Matthias Wessendorf <[email protected]>
matzew
force-pushed
the
poc_integration_source
branch
from
839abc5
to
05417aa
Compare
|
@pierDipi thanks for the review, I've addressed your comments |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: matzew, pierDipi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/unhold |
knative-prow
bot
removed
the
do-not-merge/hold
matzew
added a commit
to matzew/eventing
that referenced
this pull request
Nov 6, 2024
* Add initial raw API types and controller/reconciler. Levering internally the container source for the handling of the kamelet workloads. the logic for applying the env-vars is a bit verbose, but can be improved. Tests/lifeccyle and some other improvements are still missing. but this works. Signed-off-by: Matthias Wessendorf <[email protected]> * adding reflection to make the mapping less verbose, and more flexible to extend... Signed-off-by: Matthias Wessendorf <[email protected]> * Add DDB Streams Signed-off-by: Matthias Wessendorf <[email protected]> * polish and add minimal tests Signed-off-by: Matthias Wessendorf <[email protected]> * Update pkg/apis/sources/v1alpha1/integration_lifecycle.go Co-authored-by: Pierangelo Di Pilato <[email protected]> * Update pkg/apis/sources/v1alpha1/integration_lifecycle.go Co-authored-by: Pierangelo Di Pilato <[email protected]> * Fix compiler warnings Signed-off-by: Matthias Wessendorf <[email protected]> * use other image coordinates Signed-off-by: Matthias Wessendorf <[email protected]> * first test for source Signed-off-by: Matthias Wessendorf <[email protected]> * Adding initial rekt test Signed-off-by: Matthias Wessendorf <[email protected]> * Adding SSL support and test for IntegrationSource Signed-off-by: Matthias Wessendorf <[email protected]> * Formatting fixes Signed-off-by: Matthias Wessendorf <[email protected]> * Disable OIDC tests for now Signed-off-by: Matthias Wessendorf <[email protected]> * use knative nightly images Signed-off-by: Matthias Wessendorf <[email protected]> * Fixing linters Signed-off-by: Matthias Wessendorf <[email protected]> * addressing comments, Part1 Signed-off-by: Matthias Wessendorf <[email protected]> --------- Signed-off-by: Matthias Wessendorf <[email protected]> Co-authored-by: Pierangelo Di Pilato <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #8185
Proposed Changes
IntegrationSourceCRD and tests. Each commit has details on the implementation step or the needs (e.g. as in addressing comments too and enhancing). As alwasys, there is lot of boilerplate code when on-bording new componentPre-review Checklist
Release Note
Docs