Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update codegen to work outside GOPATH #3389

Closed
wants to merge 1 commit into from
Closed

Update codegen to work outside GOPATH #3389

wants to merge 1 commit into from

Conversation

Cynocracy
Copy link
Contributor

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jun 23, 2020
@knative-prow-robot knative-prow-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 23, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Cynocracy
To complete the pull request process, please assign chaodaig
You can assign the PR to them by writing /assign @chaodaig in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the area/test-and-release Test infrastructure, tests or release label Jun 23, 2020
matzew
matzew reviewed Jun 24, 2020
View reviewed changes
hack/patches/0001-Patch-to-fix-generate-groups.sh.patch
@@ -0,0 +1,40 @@
From 682f06406c73726775c973f9abc72a0b80a97bad Mon Sep 17 00:00:00 2001
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ideally we remove the patch, asap.

should we track it somewhere, to remove ?

e.g. GH issue ?

@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 12, 2020
@knative-prow-robot
Copy link
Contributor

@Cynocracy: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot
Copy link
Contributor

@Cynocracy: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-knative-eventing-upgrade-tests 59e0597 link /test pull-knative-eventing-upgrade-tests
pull-knative-eventing-build-tests 59e0597 link /test pull-knative-eventing-build-tests
pull-knative-eventing-conformance-tests 59e0597 link /test pull-knative-eventing-conformance-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Cynocracy
Copy link
Contributor Author

Cynocracy commented Jul 29, 2020 via email

@Cynocracy Cynocracy closed this Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matzew matzew matzew left review comments

@chizhg chizhg Awaiting requested review from chizhg

@steuhs steuhs Awaiting requested review from steuhs

Assignees
No one assigned
Labels
area/test-and-release Test infrastructure, tests or release cla: yes Indicates the PR's author has signed the CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

update-codegen.sh doesn't work outside GOPATH
4 participants
@Cynocracy @knative-prow-robot @matzew @googlebot