Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update SC members and SC permissions #1469

Merged
merged 4 commits into from
Nov 30, 2023
Merged

Update SC members and SC permissions #1469

merged 4 commits into from
Nov 30, 2023

Conversation

ReToCode
Copy link
Member

The SC election results were announced today, this PR updates the relevant configurations.

Changes

Partially #1468

@knative-prow knative-prow bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 28, 2023
@ReToCode
Copy link
Member Author

@aliok @evankanderson are those your emails you would like to use?

PTAL:
@geekygirldawn
@knative/steering-committee

lance
lance reviewed Nov 28, 2023
View reviewed changes
Copy link
Member

@lance lance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Nov 28, 2023
@psschwei psschwei removed their request for review November 28, 2023 20:14
@ReToCode
Copy link
Member Author

@nainaz @geekygirldawn gentle ping, to move ahead with SC onboarding work.

@geekygirldawn
Copy link
Member

I think we're waiting for @aliok and @evankanderson to confirm that these are the emails they want to use in those files.

@aliok
Copy link
Member

aliok commented Nov 30, 2023

are those your emails you would like to use?

Yes.

LGTM

Thanks

@dprotaso
Copy link
Member

/approve

@dprotaso
Copy link
Member

@lance can you /approve

@dprotaso
Copy link
Member

looks like this needs a rebase @ReToCode

@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 30, 2023
@knative-prow knative-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 30, 2023
@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 30, 2023
@dprotaso
Copy link
Member

OK - I rebased

@nainaz
Copy link
Contributor

nainaz commented Nov 30, 2023

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Nov 30, 2023
@knative-prow Knative Prow
Copy link

knative-prow bot commented Nov 30, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, nainaz, ReToCode

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 30, 2023
@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 30, 2023
@lance
Copy link
Member

lance commented Nov 30, 2023

ugh - needs rebase again

evankanderson
evankanderson reviewed Nov 30, 2023
View reviewed changes
Copy link
Member

@evankanderson evankanderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few touch-ups, though we could do it in a separate PR if needed.

STEERING-COMMITTEE.md Outdated Show resolved Hide resolved
groups/committee-steering/groups.yaml Outdated Show resolved Hide resolved
groups/groups.yaml Outdated Show resolved Hide resolved
@knative-prow knative-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 30, 2023
@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 30, 2023
@dprotaso
Copy link
Member

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Nov 30, 2023
@knative-prow knative-prow bot merged commit 4a74e89 into knative:main Nov 30, 2023
7 checks passed
@dprotaso
Copy link
Member

thanks everyone!

@ReToCode ReToCode mentioned this pull request Dec 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evankanderson evankanderson evankanderson left review comments

@lance lance lance left review comments

@cardil cardil Awaiting requested review from cardil

@csantanapr csantanapr Awaiting requested review from csantanapr

Assignees

@lance lance

@dprotaso dprotaso

@nainaz nainaz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@ReToCode @geekygirldawn @aliok @dprotaso @nainaz @lance @evankanderson @knative-prow-robot