Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add test cases #21

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

add test cases #21

wants to merge 2 commits into from

Conversation

misogihagi
Copy link
Contributor

id does not work

@kn1cht
Copy link
Owner

kn1cht commented Mar 10, 2024

@misogihagi Thank you for pointing this out!
When I coded this rule, I assumed that if there was a space between a number and a word, it was determined to be a number with units.
However, this assumption does not work except for languages like Japanese that do not separate words by spaces.

To remedy this, we need to fundamentally redesign the method of determining units, which will take quite some time.
I will find time to work on it, so I hope you can wait a while until then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants