Support Extended Modversions #270
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to allow longer names, the kernel is taking a new MODVERSIONS format option which stores the names in a strtab-like section and the crcs in an array-like one. This patch: 1. Makes `kmod_elf_get_modversions` use either format, preferring the new one where present. 2. Makes `kmod_elf_get_dependency_symbols` dispatch to `kmod_elf_get_modversions` rather than open-coding the same version extraction, to avoid duplicating either the old or new logic. Signed-off-by: Matthew Maurer <[email protected]>
We can't test actual CRC values, because they may vary depending on kernel configuration. We can ensure the correct symbol names show up though. Signed-off-by: Matthew Maurer <[email protected]>
|
Noticed these issues while reviewing changes: #272 Since they are already in master, I have created a new PR. No need to slow down functional review if there are bugs in the underlying base. ;) These PRs should be kept in sync, depending which one is merged first. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A companion to the
EXTENDED_MODVERSIONSkernel patch series, this PR adds support forlibkmodto access the new modversions format when present, falling back to the original format otherwise.Tested with
KDIR=override selecting a kernel withEXTENDED_MODVERSIONS=yandBASIC_MODVERSIONS=nenabled with the series above in addition to a normal existing kernel.