More cmdline test #254
Closed
More cmdline test #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evelikov
approved these changes
Nov 21, 2024
module-param-kcmdline7 was incorrectly copied inside
module-param-kcmdline{7,8}. Drop the extra dir that is not used
anywhere.
Fixes: d3a1fe6 ("libkmod-config: re-quote option from kernel cmdline")
Signed-off-by: Lucas De Marchi <[email protected]>
Reviewed-by: Emil Velikov <[email protected]>
Link: #254
Make sure this (undocumented) behavior doesn't change in future. Multiple blacklist append to the config. Signed-off-by: Lucas De Marchi <[email protected]> Reviewed-by: Emil Velikov <[email protected]> Link: #254
Simplify tests that just dump the configuration: no need to check that no module was loaded. Signed-off-by: Lucas De Marchi <[email protected]> Reviewed-by: Emil Velikov <[email protected]> Link: #254
Remove /proc/modules and /sys/module/* from the show-depends rootfs since they shouldn't be there and add a test to make sure no module is loaded. Signed-off-by: Lucas De Marchi <[email protected]>
lucasdemarchi
force-pushed
the
test-cmdline9
branch
from
6765803 to
51132cc
Compare
evelikov
approved these changes
Nov 24, 2024
lucasdemarchi
added a commit
that referenced
this pull request
Nov 29, 2024
module-param-kcmdline7 was incorrectly copied inside
module-param-kcmdline{7,8}. Drop the extra dir that is not used
anywhere.
Fixes: d3a1fe6 ("libkmod-config: re-quote option from kernel cmdline")
Signed-off-by: Lucas De Marchi <[email protected]>
Reviewed-by: Emil Velikov <[email protected]>
Link: #254
lucasdemarchi
added a commit
that referenced
this pull request
Nov 29, 2024
Make sure this (undocumented) behavior doesn't change in future. Multiple blacklist append to the config. Signed-off-by: Lucas De Marchi <[email protected]> Reviewed-by: Emil Velikov <[email protected]> Link: #254
lucasdemarchi
added a commit
that referenced
this pull request
Nov 29, 2024
Simplify tests that just dump the configuration: no need to check that no module was loaded. Signed-off-by: Lucas De Marchi <[email protected]> Reviewed-by: Emil Velikov <[email protected]> Link: #254
lucasdemarchi
added a commit
that referenced
this pull request
Nov 29, 2024
Remove /proc/modules and /sys/module/* from the show-depends rootfs since they shouldn't be there and add a test to make sure no module is loaded. Signed-off-by: Lucas De Marchi <[email protected]> Reviewed-by: Emil Velikov <[email protected]> Link: #254
|
Applied, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A question was raised today and I didn't know the answer from top of my head or looking at the documentation. Make sure this doesn't change, even if unlikely, as users rely on this behavior. While at it, cleanup.