ci/codeql: use filter-sarif to filter meson-private #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a severe number of false-positive in code scanning caused by inspecting meson-internal test files like 'build/meson-private/tmpzb46osmq/testfile.c'. As a workaround, use the 'filter-sarif' action to filter out these results before uploading the SARIF (Static Analysis Results Interchange Format). This PR was inspired by rauc/rauc#1346 and the example from https://github.com/advanced-security/filter-sarif. Signed-off-by: Enrico Joerns <[email protected]> [Emil: port from rauc, use checksums for actions] Signed-off-by: Emil Velikov <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅ 🚨 Try these New Features:
|
|
Applied, thanks |
lucasdemarchi
pushed a commit
that referenced
this pull request
Nov 19, 2024
There is a severe number of false-positive in code scanning caused by inspecting meson-internal test files like 'build/meson-private/tmpzb46osmq/testfile.c'. As a workaround, use the 'filter-sarif' action to filter out these results before uploading the SARIF (Static Analysis Results Interchange Format). This PR was inspired by rauc/rauc#1346 and the example from https://github.com/advanced-security/filter-sarif. Signed-off-by: Enrico Joerns <[email protected]> [Emil: port from rauc, use checksums for actions] Signed-off-by: Emil Velikov <[email protected]> Link: #249 Signed-off-by: Lucas De Marchi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a severe number of false-positive in code scanning caused by inspecting meson-internal test files like
'build/meson-private/tmpzb46osmq/testfile.c'.
As a workaround, use the 'filter-sarif' action to filter out these results before uploading the SARIF (Static Analysis Results Interchange Format).
This PR was inspired by rauc/rauc#1346 and the example from https://github.com/advanced-security/filter-sarif.
At a glance this will remove ~35 or around half of the reports \o/
NOTE: there is a "path-ignore" option for the scanner itself, although it seems to be language specific - see their issue 1583