libkmod: Avoid redundant kmod_pool_get_module call #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before kmod_module_new_from_path creates a module with kmod_module_new, it checks with kmod_pool_get_module if a module with given name already exists. This check can be removed, because kmod_module_new does the same. If the module already existed, the same checks are performed as in current code for the "if (m != NULL)" case. If it did not exist yet, m->path is NULL and the first if-block is entered. And since kmod_module_new takes care of incrementing the reference counter, the explicit call of kmod_module_ref can be removed from kmod_module_new_from_path as well. Signed-off-by: Tobias Stoeckmann <[email protected]>
lucasdemarchi
pushed a commit
that referenced
this pull request
Oct 1, 2024
Before kmod_module_new_from_path creates a module with kmod_module_new, it checks with kmod_pool_get_module if a module with given name already exists. This check can be removed, because kmod_module_new does the same. If the module already existed, the same checks are performed as in current code for the "if (m != NULL)" case. If it did not exist yet, m->path is NULL and the first if-block is entered. And since kmod_module_new takes care of incrementing the reference counter, the explicit call of kmod_module_ref can be removed from kmod_module_new_from_path as well. Signed-off-by: Tobias Stoeckmann <[email protected]> Reviewed-by: Emil Velikov <[email protected]> Link: #168 Signed-off-by: Lucas De Marchi <[email protected]>
|
Applied, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before kmod_module_new_from_path creates a module with kmod_module_new, it checks with kmod_pool_get_module if a module with given name already exists.
This check can be removed, because kmod_module_new does the same. If the module already existed, the same checks are performed as in current code for the "if (m != NULL)" case. If it did not exist yet, m->path is NULL and the first if-block is entered.
And since kmod_module_new takes care of incrementing the reference counter, the explicit call of kmod_module_ref can be removed from kmod_module_new_from_path as well.