libkmod: Improve strbuf handling in libkmod-index.c #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
... and fixed a typo while at it. |
evelikov
approved these changes
Sep 25, 2024
There was a problem hiding this comment.
Food for thought : If we're willing to live with a small hack, we can fold have a single index_mm_node and index_node_f alongside a bunch of the helpers.index_node struct instead of mm and f variants, which will allow us to also de-duplicate the helpers.
This PR looks good though.
stoeckmann
force-pushed
the
index_strbuf
branch
2 times, most recently
from
abfbcb2 to
8e014fc
Compare
The unsigned int data type might be too small on 64 bit systems and when encountering huge and illegal index files. Since lengths are retrieved from strbuf structs, this also keeps the data type lengths in sync. Signed-off-by: Tobias Stoeckmann <[email protected]>
The strbuf functions may fail, so handle errors. Make especially sure that push and pop operations stay in sync. Signed-off-by: Tobias Stoeckmann <[email protected]>
Signed-off-by: Tobias Stoeckmann <[email protected]>
stoeckmann
force-pushed
the
index_strbuf
branch
from
8e014fc to
26d31ed
Compare
lucasdemarchi
pushed a commit
that referenced
this pull request
Oct 1, 2024
The unsigned int data type might be too small on 64 bit systems and when encountering huge and illegal index files. Since lengths are retrieved from strbuf structs, this also keeps the data type lengths in sync. Signed-off-by: Tobias Stoeckmann <[email protected]> Reviewed-by: Emil Velikov <[email protected]> Link: #152 Signed-off-by: Lucas De Marchi <[email protected]>
lucasdemarchi
pushed a commit
that referenced
this pull request
Oct 1, 2024
The strbuf functions may fail, so handle errors. Make especially sure that push and pop operations stay in sync. Signed-off-by: Tobias Stoeckmann <[email protected]> Reviewed-by: Emil Velikov <[email protected]> Link: #152 Signed-off-by: Lucas De Marchi <[email protected]>
lucasdemarchi
pushed a commit
that referenced
this pull request
Oct 1, 2024
Signed-off-by: Tobias Stoeckmann <[email protected]> Reviewed-by: Emil Velikov <[email protected]> Link: #152 Signed-off-by: Lucas De Marchi <[email protected]>
|
Applied, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
unsigned intlengths intosize_tto stay in sync with latest strbuf changes