Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: bump github/codeql-action from 3.26.7 to 3.26.8 in the all-actions group #146

Closed

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Sep 22, 2024

Bumps the all-actions group with 1 update: github/codeql-action.

Updates github/codeql-action from 3.26.7 to 3.26.8

Changelog

Sourced from github/codeql-action's changelog.

CodeQL Action Changelog

See the releases page for the relevant changes to the CodeQL CLI and language packs.

Note that the only difference between v2 and v3 of the CodeQL Action is the node version they support, with v3 running on node 20 while we continue to release v2 to support running on node 16. For example 3.22.11 was the first v3 release and is functionally identical to 2.22.11. This approach ensures an easy way to track exactly which features are included in different versions, indicated by the minor and patch version numbers.

[UNRELEASED]

No user facing changes.

3.26.8 - 19 Sep 2024

  • Update default CodeQL bundle version to 2.19.0. #2483

3.26.7 - 13 Sep 2024

  • Update default CodeQL bundle version to 2.18.4. #2471

3.26.6 - 29 Aug 2024

  • Update default CodeQL bundle version to 2.18.3. #2449

3.26.5 - 23 Aug 2024

  • Fix an issue where the csrutil system call used for telemetry would fail on MacOS ARM machines with System Integrity Protection disabled. #2441

3.26.4 - 21 Aug 2024

  • Deprecation: The add-snippets input on the analyze Action is deprecated and will be removed in the first release in August 2025. #2436
  • Fix an issue where the disk usage system call used for telemetry would fail on MacOS ARM machines with System Integrity Protection disabled, and then surface a warning. The system call is now disabled for these machines. #2434

3.26.3 - 19 Aug 2024

  • Fix an issue where the CodeQL Action could not write diagnostic messages on Windows. This issue did not impact analysis quality. #2430

3.26.2 - 14 Aug 2024

  • Update default CodeQL bundle version to 2.18.2. #2417

3.26.1 - 13 Aug 2024

No user facing changes.

3.26.0 - 06 Aug 2024

  • Deprecation: Swift analysis on Ubuntu runner images is no longer supported. Please migrate to a macOS runner if this affects you. #2403
  • Bump the minimum CodeQL bundle version to 2.13.5. #2408

3.25.15 - 26 Jul 2024

... (truncated)

Commits
  • 294a9d9 Merge pull request #2490 from github/update-v3.26.8-64431c66d
  • 00b3604 Update changelog for v3.26.8
  • 64431c6 Merge pull request #2483 from github/update-bundle/codeql-bundle-v2.19.0
  • e0e2d75 Merge branch 'main' into update-bundle/codeql-bundle-v2.19.0
  • cb28816 Merge pull request #2487 from rvermeulen/rvermeulen/uri-errors-as-warnings
  • 498c508 Rebuild JavaScript files
  • a1a585f Merge branch 'main' into rvermeulen/uri-errors-as-warnings
  • 34666c1 Merge pull request #2488 from github/henrymercer/debug-artifacts-better-logging
  • 6e24973 Improve logging for combined SARIF debug artifact
  • d0a3cf2 Improve logging for debug artifacts
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore <dependency name> major version will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)
  • @dependabot ignore <dependency name> minor version will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)
  • @dependabot ignore <dependency name> will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)
  • @dependabot unignore <dependency name> will remove all of the ignore conditions of the specified dependency
  • @dependabot unignore <dependency name> <ignore condition> will remove the ignore condition of the specified dependency and ignore conditions

@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Sep 22, 2024
@lucasdemarchi
Copy link
Contributor

@evelikov is it going to be this annoying? I don't feel like tracking the minor version if we have to keep applying 1 commit every week to update it

@dependabot dependabot bot force-pushed the dependabot/github_actions/all-actions-366513d706 branch from bca2959 to 14a3db4 Compare September 23, 2024 01:11
@evelikov
Copy link
Collaborator

I think the key point is that codeql (or github actions as a whole I believe) rewrite the major tag. So as 3.26.8 is released, the v3 gets force-pushed pointing to it.

Which is the key point why security people recommend using hashes, instead of tags.

I hope that codeql are being temporarily overzealous with the releases, but if it's too annoying feel free to switch to v3.

@evelikov
Copy link
Collaborator

Looking through their 3.26 and 3.25 tags ... it's 1-2 tags every week. Which is borderline ridiculous IMHO - will open an issue asking them to reconsider.

In the meantime - do whatever you think is best. Even if that means removing/disabling the action.

@evelikov
Copy link
Collaborator

We can also change depenabot to check monthly for updates - depehttps://github.com//pull/150

@lucasdemarchi
Copy link
Contributor

lucasdemarchi commented Sep 23, 2024

Which is the key point why security people recommend using hashes, instead of tags.

what's the benefit if then dependabot raises a PR with the update? I'm certainly not going to review once a week or once a month when codeql is updated. As long as codeql has a readonly token, I don't really care if it's running 3.26.5 or 3.26.7. The only issue would be if it started to cause noise with different results depending on the version used. But in that case we should then consider disabling the whole thing as it's useless.

@evelikov
Copy link
Collaborator

Unlike other actions, this one has security-events: write.

Personally I skim through the action change log, although it's by no means a full/proper audit or anything. I don't have an opinion - I suggest using what you feel most comfortable with.

@dependabot dependabot bot force-pushed the dependabot/github_actions/all-actions-366513d706 branch from 14a3db4 to 669b4b6 Compare September 24, 2024 14:17
dependabot bot and others added 2 commits September 24, 2024 09:18
Bumps the all-actions group with 1 update: [github/codeql-action](https://github.com/github/codeql-action).

Updates `github/codeql-action` from 3.26.7 to 3.26.8
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](github/codeql-action@8214744...294a9d9)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: all-actions
...

Signed-off-by: dependabot[bot] <[email protected]>
Link: #146
Signed-off-by: Lucas De Marchi <[email protected]>
@lucasdemarchi lucasdemarchi force-pushed the dependabot/github_actions/all-actions-366513d706 branch from 669b4b6 to 6714d2a Compare September 24, 2024 14:19
Copy link
Contributor Author

dependabot bot commented on behalf of github Oct 1, 2024

Looks like github/codeql-action is updatable in another way, so this is no longer needed.

@dependabot dependabot bot closed this Oct 1, 2024
@dependabot dependabot bot deleted the dependabot/github_actions/all-actions-366513d706 branch October 1, 2024 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants