Prep and add CodeQL action #132
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
lucasdemarchi
requested changes
Sep 16, 2024
Our jobs are pretty quick sub 2m for meson builds and sub 1m, when if going without tests. Wait for all jobs so we get all the (potential) issues at once. Signed-off-by: Emil Velikov <[email protected]>
We'll be adding another action, where this script is handy. Flesh it out to scripts and convert to bash. v2: - move script to .github/ Signed-off-by: Emil Velikov <[email protected]>
Signed-off-by: Emil Velikov <[email protected]>
Effectively a trimmed down copy of main.yml, running only on ubuntu-22.04 for now. The action flags a handful of interesting issues and allows us to prevent more from creeping in. The action does not need need docs/manpages so we disable those. v2: - script lives in .github/ Signed-off-by: Emil Velikov <[email protected]>
lucasdemarchi
pushed a commit
that referenced
this pull request
Sep 17, 2024
Our jobs are pretty quick sub 2m for meson builds and sub 1m, when if going without tests. Wait for all jobs so we get all the (potential) issues at once. Signed-off-by: Emil Velikov <[email protected]> Link: #132 Signed-off-by: Lucas De Marchi <[email protected]>
lucasdemarchi
pushed a commit
that referenced
this pull request
Sep 17, 2024
We'll be adding another action, where this script is handy. Flesh it out to scripts and convert to bash. v2: - move script to .github/ Signed-off-by: Emil Velikov <[email protected]> Link: #132 Signed-off-by: Lucas De Marchi <[email protected]>
lucasdemarchi
pushed a commit
that referenced
this pull request
Sep 17, 2024
Signed-off-by: Emil Velikov <[email protected]> Link: #132 Signed-off-by: Lucas De Marchi <[email protected]>
lucasdemarchi
pushed a commit
that referenced
this pull request
Sep 17, 2024
Effectively a trimmed down copy of main.yml, running only on ubuntu-22.04 for now. The action flags a handful of interesting issues and allows us to prevent more from creeping in. The action does not need need docs/manpages so we disable those. v2: - script lives in .github/ Signed-off-by: Emil Velikov <[email protected]> Link: #132 Signed-off-by: Lucas De Marchi <[email protected]>
|
Applied, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor prep + bugfix alongside adding the action itself. It flags some ~90 issues atm, which we'll go through as time permits.
At a glance there is nothing too critical in there, but who knows.