Skip to content

Commit

Permalink
ci: Fix fail due to existent build dir
Browse files Browse the repository at this point in the history
The second check is a "should fail" check, but it will fail because the
build dir already exists rather than for the true reason. Use a
different dir for the configure tests and move the `rm` inside the
function.

Signed-off-by: Lucas De Marchi <[email protected]>
  • Loading branch information
lucasdemarchi committed Dec 5, 2024
1 parent a848bbf commit d6610b3
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -74,14 +74,14 @@ jobs:
if: ${{ matrix.build == 'meson' }}
run: |
should_fail() {
if meson setup "$@" build/; then
rm -rf build-setup-test/
if meson setup "$@" build-setup-test/; then
echo Command was expected to fail, but was successful
return 1
fi
}
should_fail -D distconfdir=relative/
should_fail -D moduledir=relative/
rm -rf build/
- name: configure (meson)
if: ${{ matrix.build == 'meson' }}
Expand Down

0 comments on commit d6610b3

Please sign in to comment.