Skip to content

Commit

Permalink
build: force char to unsigned-char
Browse files Browse the repository at this point in the history
Handful of places throughout the codebase rely on the data to be
unsigned char. While most of those should be addressed now, one could
argue that we should be switching the default and resolve the whole
class of issues, instead of playing whack-a-mole by fixing individual
bugs.

Signed-off-by: Emil Velikov <[email protected]>
  • Loading branch information
evelikov committed Nov 16, 2024
1 parent c78b364 commit 84f6a65
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 0 deletions.
1 change: 1 addition & 0 deletions configure.ac
Original file line number Diff line number Diff line change
Expand Up @@ -261,6 +261,7 @@ CC_CHECK_FLAGS_APPEND(with_cflags, [CFLAGS], [\
-fdiagnostics-show-option \
-ffunction-sections \
-fno-common \
-funsigned-char \
-fvisibility=hidden \
-W \
-Wall \
Expand Down
1 change: 1 addition & 0 deletions meson.build
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,7 @@ add_project_arguments(
'-fdiagnostics-show-option',
'-ffunction-sections',
'-fno-common',
'-funsigned-char',
'-Wchar-subscripts',
'-Wdeclaration-after-statement',
'-Wendif-labels',
Expand Down

0 comments on commit 84f6a65

Please sign in to comment.