libkmod: Fix file error handling regression

The propagation of errors from loading function through errno must make sure that errno is positive, otherwise errors are not correctly spotted. Signed-off-by: Tobias Stoeckmann <[email protected]>
kmod-project · Nov 13, 2024 · 31067d7 · 31067d7
1 parent 5c24480
commit 31067d7
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/libkmod/libkmod-file-zstd.c b/libkmod/libkmod-file-zstd.c
@@ -67,6 +67,7 @@ int kmod_file_load_zstd(struct kmod_file *file)
 	ret = ZSTD_decompress(dst_buf, dst_size, src_buf, src_size);
 	if (ZSTD_isError(ret)) {
 		ERR(file->ctx, "zstd: %s\n", ZSTD_getErrorName(ret));
+		ret = -EINVAL;
 		goto out;
 	}
 

diff --git a/libkmod/libkmod-file.c b/libkmod/libkmod-file.c
@@ -67,7 +67,7 @@ struct kmod_elf *kmod_file_get_elf(struct kmod_file *file)
 
 	err = kmod_file_load_contents(file);
 	if (err) {
-		errno = err;
+		errno = -err;
 		return NULL;
 	}