[WIP]Introduce eBPF prog coverage #692
Conversation
kmesh-bot
added
kind/enhancement
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
How to generate coverage(This is a temporary way to generate coverage, and will be optimized in future work)
Coverage HTML sample: |
can you introduct it at Thursday's community meeting? |
Sure |
Signed-off-by: talon <[email protected]>
|
/retest |
| // Create parameter logWriter passed to coverbee InstrumentAndLoadCollection() | ||
| logFile, err := os.Create("/kmesh/instrument-load.log") | ||
| if err != nil { | ||
| return nil, fmt.Errorf("open log file: %w", err) |
There was a problem hiding this comment.
| return nil, fmt.Errorf("open log file: %w", err) | |
| return nil, fmt.Errorf("create log file failed: %w", err) |
| } | ||
| so.Coll = coll | ||
|
|
||
| if GetStartType() == Restart { |
There was a problem hiding this comment.
Both branches have this if, is it possible to extract this if outside
|
To be discussed:
TODO: |
What type of PR is this?
/kind enhancement
What this PR does / why we need it:
Introduce eBPF prog coverage
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: