Fix linter warning

Signed-off-by: Tamal Saha <[email protected]>
kluster-manager · Jan 13, 2024 · be1e73c · be1e73c
1 parent e131082
commit be1e73c
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/Makefile b/Makefile
@@ -402,7 +402,7 @@ lint: $(BUILD_DIRS)
  --env HTTPS_PROXY=$(HTTPS_PROXY) \
  --env GOFLAGS="-mod=vendor" \
  $(BUILD_IMAGE) \
- golangci-lint run --enable $(ADDTL_LINTERS) --timeout=10m --skip-files="generated.*\.go$\" --skip-dirs-use-default --skip-dirs=client,vendor
+ golangci-lint run --enable $(ADDTL_LINTERS) --max-same-issues=100 --timeout=10m --skip-files="generated.*\.go$\" --skip-dirs-use-default --skip-dirs=client,vendor
 
 $(BUILD_DIRS):
  @mkdir -p $@

diff --git a/pkg/manager/manager.go b/pkg/manager/manager.go
@@ -97,7 +97,7 @@ func runManagerController(ctx context.Context, kubeConfig *rest.Config) error {
  WithCreateAgentInstallNamespace().
  BuildHelmAgentAddon()
  if err != nil {
- klog.Error("Failed to build agent: `%v`", err)
+ klog.Errorf("Failed to build agent: `%v`", err)
  return err
  }
 
@@ -106,7 +106,10 @@ func runManagerController(ctx context.Context, kubeConfig *rest.Config) error {
  return err
  }
 
- go mgr.Start(ctx)
+ err = mgr.Start(ctx)
+ if err != nil {
+ return err
+ }
  <-ctx.Done()
 
  return nil