Skip to content

Commit

Permalink
Merge branch 'master' into german
Browse files Browse the repository at this point in the history
  • Loading branch information
klushy225 authored Feb 27, 2024
2 parents 0ac96c2 + 97db29c commit 10a7b28
Show file tree
Hide file tree
Showing 781 changed files with 32,594 additions and 19,801 deletions.
2 changes: 1 addition & 1 deletion +secret
2 changes: 1 addition & 1 deletion .github/CODE_GUIDELINES.md
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ It's also faster (~6%), for internal bytecode reasons (which don't really matter

## Abstract types and typesof

Some types exist just as a parent and should never be created in-game (e.g. `/obj/item`). Mark those using the `ABSTRACT_TYPE(type)` macro. You can check if a type is abstract using the `IS_ABSTRACT(type)` macro.
Some types exist just as a parent and should never be created in-game (e.g. `/obj/item`). Mark those using the `ABSTRACT_TYPE(/type)` macro. You can check if a type is abstract using the `IS_ABSTRACT(/type)` macro.

To get a list of all concrete (non-abstract) subtypes of a type you should use `concrete_typesof(type)`, the result is cached so no need to store it yourself. (As a consequence please `.Copy` the list if you want to make changes to it locally.) Proper usage of `ABSTRACT_TYPE` + `concrete_typesof` is preferred to using `typesof` and `childrentypesof` *usually* though exceptions apply.

Expand Down
48 changes: 38 additions & 10 deletions .github/workflows/automaton.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,18 +11,32 @@ on:
- "master"

jobs:

runtime:
name: Runtime Checker
runs-on: ubuntu-22.04
if: "!contains(github.event.head_commit.message, 'skip ci')"
strategy:
fail-fast: false
matrix:
map: ["COGMAP", "COGMAP2", "CLARION", "DONUT3", "DONUT2", "OSHAN", "KONDARU", "NADIR", "ATLAS", "SPACE_PREFAB", "UNDERWATER_PREFAB", "RANDOM_ROOMS", "FULL"]
map:
[
"COGMAP",
"COGMAP2",
"CLARION",
"DONUT3",
"DONUT2",
"OSHAN",
"KONDARU",
"NADIR",
"ATLAS",
"SPACE_PREFAB",
"UNDERWATER_PREFAB",
"RANDOM_ROOMS",
"FULL",
]
compiletype: ["default"]
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4

- name: Install Dependencies
run: |
Expand All @@ -32,7 +46,7 @@ jobs:
sudo apt install -o APT::Immediate-Configure=false libssl-dev:i386 libgcc-s1:i386
- name: Cache BYOND
uses: actions/cache@v3
uses: actions/cache@v4
with:
path: ~/BYOND
key: ${{ runner.os }}-byond-${{ hashFiles('buildByond.conf')}}
Expand Down Expand Up @@ -95,14 +109,28 @@ jobs:
strategy:
fail-fast: false
matrix:
map: ["COGMAP", "COGMAP2", "CLARION", "DONUT3", "DONUT2", "OSHAN", "KONDARU", "NADIR", "ATLAS", "SPACE_PREFAB", "UNDERWATER_PREFAB", "FULL"]
map:
[
"COGMAP",
"COGMAP2",
"CLARION",
"DONUT3",
"DONUT2",
"OSHAN",
"KONDARU",
"NADIR",
"ATLAS",
"SPACE_PREFAB",
"UNDERWATER_PREFAB",
"FULL",
]
compiletype: ["default"]

steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
with:
submodules: true
token: '${{ secrets.ROBUDDYBOT_PAT }}'
token: "${{ secrets.ROBUDDYBOT_PAT }}"

- name: Install Dependencies
run: |
Expand All @@ -112,7 +140,7 @@ jobs:
sudo apt install -o APT::Immediate-Configure=false libssl-dev:i386 libgcc-s1:i386
- name: Cache BYOND
uses: actions/cache@v3
uses: actions/cache@v4
with:
path: ~/BYOND
key: ${{ runner.os }}-byond-${{ hashFiles('buildByond.conf')}}
Expand Down Expand Up @@ -167,7 +195,7 @@ jobs:
runs-on: ubuntu-22.04
if: "!contains(github.event.head_commit.message, 'skip ci')"
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4

- name: Install Dependencies
run: |
Expand All @@ -177,7 +205,7 @@ jobs:
sudo apt install -o APT::Immediate-Configure=false libssl-dev:i386 libgcc-s1:i386
- name: Cache BYOND
uses: actions/cache@v3
uses: actions/cache@v4
with:
path: ~/BYOND
key: ${{ runner.os }}-byond-${{ hashFiles('buildByond.conf')}}
Expand Down
27 changes: 19 additions & 8 deletions .github/workflows/beepsky.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,13 +17,13 @@ jobs:
- uses: actions/checkout@v4

- name: Cache SpacemanDMM
uses: actions/cache@v3
uses: actions/cache@v4
with:
path: $HOME/SpacemanDMM
key: ${{ runner.os }}-spacemandmm

- name: Setup Rust
uses: hecrj/setup-rust-action@v1.4.1
uses: hecrj/setup-rust-action@v2.0.0

- name: Install Dependencies
run: |
Expand All @@ -33,15 +33,26 @@ jobs:
tools/bootstrap/python -c ''
touch +secret/__secret.dme
- name: Check TGUI
run: |
tools/ci/build_tgui.sh
- name: Misc Checks
run: |
tools/ci/check_filedirs.sh goonstation.dme
tools/ci/build_tgui.sh
tools/ci/check_grep.sh
tools/bootstrap/python tools/ci/validate_dme.py <goonstation.dme
- name: Check Maps
run: |
tools/bootstrap/python -m dmi.test
tools/bootstrap/python -m mapmerge2.dmm_test
- name: Check Duplicate DMI Icon States
uses: spacestation13/dmi-duplicate-state-checker@v1
with:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

- name: Run Linter
id: linter
run: |
Expand All @@ -62,7 +73,7 @@ jobs:
uses: actions/setup-dotnet@v3
with:
dotnet-version: "7.0"
- uses: actions/cache@v3
- uses: actions/cache@v4
with:
path: ~/.nuget/packages
key: ${{ runner.os }}-nuget-od-${{ hashFiles('OpenDream/**/*.csproj') }}
Expand All @@ -82,7 +93,7 @@ jobs:
- uses: actions/checkout@v4

- name: Cache BYOND
uses: actions/cache@v3
uses: actions/cache@v4
with:
path: $HOME/BYOND
key: ${{ runner.os }}-byond
Expand All @@ -109,7 +120,7 @@ jobs:
# cp goonstation.rsc artifacts

# - name: Upload Artifacts
# uses: actions/upload-artifact@v1
# uses: actions/upload-artifact@v4
# with:
# name: DMB + RSC
# path: ${{github.workspace}}/artifacts
Expand All @@ -126,7 +137,7 @@ jobs:
token: "${{ secrets.ROBUDDYBOT_PAT }}"

- name: Cache BYOND
uses: actions/cache@v3
uses: actions/cache@v4
with:
path: $HOME/BYOND
key: ${{ runner.os }}-byond
Expand All @@ -142,7 +153,7 @@ jobs:
echo "MANPATH=/home/runner/BYOND/byond/man:$MANPATH" >> $GITHUB_ENV
- name: Cache SpacemanDMM
uses: actions/cache@v3
uses: actions/cache@v4
with:
path: $HOME/SpacemanDMM
key: ${{ runner.os }}-spacemandmm
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/final_review_labeler.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:
if: ${{ github.event.workflow_run.conclusion == 'success' }}
steps:
- name: "Download artifact"
uses: actions/github-script@v6
uses: actions/github-script@v7
with:
script: |
let allArtifacts = await github.rest.actions.listWorkflowRunArtifacts({
Expand All @@ -39,7 +39,7 @@ jobs:
- name: "Unzip artifact"
run: unzip pr_number.zip

- uses: actions/github-script@v6
- uses: actions/github-script@v7
id: set-pr-number
with:
script: |
Expand Down Expand Up @@ -67,7 +67,7 @@ jobs:
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

- uses: actions/github-script@v6
- uses: actions/github-script@v7
with:
# Only on totalCount == 2 or 3 so maintainers can remove the label and it won't get re-applied (3 for fast approvals due to script delay)
script: |
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/final_review_labeler_dummy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:
run: |
mkdir -p ./pr
echo $PR_NUMBER > ./pr/pr_number
- uses: actions/upload-artifact@v3
- uses: actions/upload-artifact@v4
with:
name: pr_number
path: pr/
67 changes: 33 additions & 34 deletions .github/workflows/forum_pr_poster.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,40 +8,39 @@ jobs:
runs-on: ubuntu-latest
if: ${{ github.repository == 'goonstation/goonstation' && (github.event.action == 'labeled' && github.event.label.name == 'E-Input-Wanted' || github.event.action != 'labeled' && contains(github.event.pull_request.labels.*.name, 'E-Input-Wanted')) }}
steps:
- name: Get The Script
run: |
wget "https://raw.githubusercontent.com/${{ github.repository }}/master/.github/post_to_forums.py"
- name: Get The Script
run: |
wget "https://raw.githubusercontent.com/${{ github.repository }}/master/.github/post_to_forums.py"
- name: Set up Python
uses: actions/setup-python@v5
with:
python-version: 3.8

- name: Set up Python
uses: actions/setup-python@v4
with:
python-version: 3.8
- name: Install dependencies
run: |
python -m pip install --upgrade pip
pip install pygithub requests
- name: Install dependencies
run: |
python -m pip install --upgrade pip
pip install pygithub requests
- name: Post the thread
run: |
python post_to_forums.py
env:
TOKEN: ${{ secrets.GITHUB_TOKEN }}
REPO: ${{ github.repository }}
FORUM_URL: "https://forum.ss13.co"
FORUM_PASSWORD: ${{ secrets.FORUM_PASSWORD }}
FORUM_USERNAME: "github_bot"
SUBFORUM_ID: 8 # Ideas & Suggestions
POST_ICON: 11 #
POST_ICON_CLOSED: 18 # 👎
POST_ICON_MERGED: 19 # 👍
SUBJECT_PREFIX: "[PR] "
SUBJECT_PREFIX_CLOSED: "[CLOSED PR] "
SUBJECT_PREFIX_MERGED: "[MERGED PR] "
PR_TITLE: ${{ github.event.pull_request.title }}
PR_BODY: ${{ github.event.pull_request.body }}
PR_URL: ${{ github.event.pull_request.html_url }}
PR_NUM: ${{ github.event.pull_request.number }}
PR_STATE: ${{ github.event.pull_request.state }}
PR_MERGED: ${{ github.event.pull_request.merged }}
- name: Post the thread
run: |
python post_to_forums.py
env:
TOKEN: ${{ secrets.GITHUB_TOKEN }}
REPO: ${{ github.repository }}
FORUM_URL: "https://forum.ss13.co"
FORUM_PASSWORD: ${{ secrets.FORUM_PASSWORD }}
FORUM_USERNAME: "github_bot"
SUBFORUM_ID: 8 # Ideas & Suggestions
POST_ICON: 11 #
POST_ICON_CLOSED: 18 # 👎
POST_ICON_MERGED: 19 # 👍
SUBJECT_PREFIX: "[PR] "
SUBJECT_PREFIX_CLOSED: "[CLOSED PR] "
SUBJECT_PREFIX_MERGED: "[MERGED PR] "
PR_TITLE: ${{ github.event.pull_request.title }}
PR_BODY: ${{ github.event.pull_request.body }}
PR_URL: ${{ github.event.pull_request.html_url }}
PR_NUM: ${{ github.event.pull_request.number }}
PR_STATE: ${{ github.event.pull_request.state }}
PR_MERGED: ${{ github.event.pull_request.merged }}
57 changes: 28 additions & 29 deletions .github/workflows/merge_upstream.yml
Original file line number Diff line number Diff line change
@@ -1,41 +1,40 @@
name: merge_upstream
on:
issue_comment:
types: [ created ]
types: [created]

jobs:
merge-upstream:
if: ${{ github.event.issue.pull_request && github.event.comment.body == '!merge_upstream' }}
runs-on: ubuntu-22.04
steps:
- name: PR Data
run: |
curl -H "Authorization: token ${{ github.token }}" ${{ github.event.issue.pull_request.url }} > pr.json
echo "PR_REPO=`jq -r '.head.repo.full_name' < pr.json`" >> $GITHUB_ENV
echo "PR_BRANCH=`jq -r '.head.ref' < pr.json`" >> $GITHUB_ENV
- name: PR Data
run: |
curl -H "Authorization: token ${{ github.token }}" ${{ github.event.issue.pull_request.url }} > pr.json
echo "PR_REPO=`jq -r '.head.repo.full_name' < pr.json`" >> $GITHUB_ENV
echo "PR_BRANCH=`jq -r '.head.ref' < pr.json`" >> $GITHUB_ENV
- uses: actions/checkout@v4
with:
repository: ${{ env.PR_REPO }}
ref: ${{ env.PR_BRANCH }}
fetch-depth: 0

- uses: actions/checkout@v3
with:
repository: ${{ env.PR_REPO }}
ref: ${{ env.PR_BRANCH }}
fetch-depth: 0
- name: Perform Merge
run: |
bash tools/hooks/install.sh
bash tools/ci/install_build_tools.sh
bash tgui/bin/tgui --install-git-hooks
chmod +x tools/hooks/*.merge tgui/bin/tgui
git config user.name github-actions
git config user.email [email protected]
git remote add upstream "https://github.com/${{ github.repository }}.git"
git fetch upstream master
git merge upstream/master && git push origin
- name: Perform Merge
run: |
bash tools/hooks/install.sh
bash tools/ci/install_build_tools.sh
bash tgui/bin/tgui --install-git-hooks
chmod +x tools/hooks/*.merge tgui/bin/tgui
git config user.name github-actions
git config user.email [email protected]
git remote add upstream "https://github.com/${{ github.repository }}.git"
git fetch upstream master
git merge upstream/master && git push origin
- name: Notify Failure
if: failure()
run: |
curl -s -H "Authorization: token ${{ github.token }}" \
-X POST -d '{"body": "Merging upstream failed:\nhttps://github.com/${{ github.repository }}/actions/runs/${{ github.run_id }}"}' \
"https://api.github.com/repos/${{ github.repository }}/issues/${{ github.event.issue.number }}/comments"
- name: Notify Failure
if: failure()
run: |
curl -s -H "Authorization: token ${{ github.token }}" \
-X POST -d '{"body": "Merging upstream failed:\nhttps://github.com/${{ github.repository }}/actions/runs/${{ github.run_id }}"}' \
"https://api.github.com/repos/${{ github.repository }}/issues/${{ github.event.issue.number }}/comments"
Loading

0 comments on commit 10a7b28

Please sign in to comment.