Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(atlas): option to pass aws_kms config values as seperate variables #217

Merged
merged 1 commit into from
May 15, 2024
Merged

feat(atlas): option to pass aws_kms config values as seperate variables #217

merged 1 commit into from
May 15, 2024

Conversation

akcinardoga
Copy link
Contributor

No description provided.

ehakan
ehakan approved these changes May 15, 2024
View reviewed changes
Copy link
Contributor

@ehakan ehakan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, also are there any plans to deprecate the old values in a later major release?

@akcinardoga
Copy link
Contributor Author

LGTM, also are there any plans to deprecate the old values in a later major release?

Didn't think of it at first but would be a valid option to decrease complexity

@akcinardoga akcinardoga merged commit b9938bc into main May 15, 2024
1 check passed
@kloia-tfmodules-releaser kloia-tfmodules-releaser bot mentioned this pull request May 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehakan ehakan ehakan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@akcinardoga @ehakan