Skip to content

Commit

Permalink
feat(rds-aurora)!: add apply method (#227)
Browse files Browse the repository at this point in the history
BREAKING CHANGE: needs apply method to be supplied for all parameter
groups
  • Loading branch information
ariqf79 authored May 23, 2024
1 parent 5dd76f0 commit 1aee7e3
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 5 deletions.
5 changes: 3 additions & 2 deletions modules/aws-rds-aurora/sql-server.tf
Original file line number Diff line number Diff line change
Expand Up @@ -270,8 +270,9 @@ resource "aws_db_parameter_group" "sql_server" {
dynamic "parameter" {
for_each = var.enable_custom_parameter_group ? var.parameter_group : []
content {
name = parameter.value.parameter_name
value = parameter.value.parameter_value
name = parameter.value.parameter_name
value = parameter.value.parameter_value
apply_method = parameter.value.parameter_apply_method
}
}
}
Expand Down
7 changes: 4 additions & 3 deletions modules/aws-rds-aurora/variables.tf
Original file line number Diff line number Diff line change
Expand Up @@ -552,8 +552,9 @@ variable "option_group" {

variable "parameter_group" {
type = list(object({
parameter_name = string
parameter_value = any
parameter_name = string
parameter_value = any
parameter_apply_method = string
}))
}

Expand Down Expand Up @@ -785,4 +786,4 @@ variable "kms_multi_region" {
description = "Determine whether the KMS key is multi region support"
type = bool
default = false
}
}

0 comments on commit 1aee7e3

Please sign in to comment.