add disabled status to file input #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -16,6 +16,7 @@ export class FileInputComponent extends MultipleValueAccessorBase<File> { | |||
| @Input() onlyShowUploadButton = false; | |||
| @Input() useFullParentSize = false; | |||
| @Input() buttonText: string = 'Upload a file'; | |||
| @Input() disabled: boolean = false; | |||
There was a problem hiding this comment.
valueAccessorBase already has this property, which you are extending from
There was a problem hiding this comment.
indeed i only checked the parent for the inputs. Fixed in the next commit
joaomsg11
force-pushed
the
make_file_input_disabled_via_input
branch
from
c67d68d
to
e5cd172
Compare
wouter-willems
approved these changes
Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.