Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add submit validation errors #35

Merged
merged 7 commits into from
Oct 11, 2023
Merged

Add submit validation errors #35

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
8749982
chore: add flake shell
Sep 25, 2023
0c75da0
chore: remove package-lock.json
Sep 25, 2023
3e68270
feat: add routing to demo app
Sep 25, 2023
474e0eb
chore: stub expected usage
Sep 25, 2023
80788df
refactor: simplify on submit promise logic
Sep 25, 2023
377de2c
refactor: alter to match usage described by @jerbob, and extract erro…
Oct 4, 2023
ccfb854
chore: implement changes from review
Oct 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,3 +46,15 @@ testem.log
# System Files
.DS_Store
Thumbs.db


# yarn v3
.yarn/*
.yarnrc.yml

# direnv / nix
.direnv/*
.envrc

# @olistrik
.vimignore
58 changes: 58 additions & 0 deletions flake.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

26 changes: 26 additions & 0 deletions flake.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
# https://github.com/numtide/devshell
Copy link
Contributor Author

@olistrik olistrik Oct 4, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this file shouldn't have ended up in here, I made a seperate branch for it, but rebase go burr i guess.

I can't develop without it as it sets up node 16 (which is no longer maintained btw, so nixos considers it insecure).

flake.nix can't, and shouldn't be, git ignored. Having to remake and remove this file every time I need to work on enhancy forms is really irritating, so it would be very helpful for me if this is in version control.

{
description = "nix is love, nix is life";
inputs.flake-utils.url = "github:numtide/flake-utils";
outputs = { self, flake-utils, nixpkgs }:
flake-utils.lib.eachDefaultSystem (system:
let
overlays = [ ];
pkgs = import nixpkgs {
inherit system overlays;
config = { permittedInsecurePackages = [ "nodejs-16.20.2" ]; };
};

PROJECT_ROOT = builtins.toString "$PWD";

nodejs = pkgs.nodejs-16_x;
yarn = pkgs.yarn.override { inherit nodejs; };
npm = pkgs.npm.override { inherit npm; };

in with pkgs; {
devShells.default = mkShell {
buildInputs = [ yarn nodejs ];
shellHook = ''export PATH="$PATH:${PROJECT_ROOT}/node_modules/.bin"'';
};
});
}
Loading
Loading