optimize formElement scroll

klippa-app · Oct 7, 2024 · f261bd1 · f261bd1
1 parent 1b8aa7c
commit f261bd1
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 11 deletions.
diff --git a/projects/klippa/ngx-enhancy-forms/package.json b/projects/klippa/ngx-enhancy-forms/package.json
@@ -1,6 +1,6 @@
 {
  "name": "@klippa/ngx-enhancy-forms",
- "version": "18.23.7",
+ "version": "18.23.8",
  "publishConfig": {
  "access": "public"
  },

diff --git a/projects/klippa/ngx-enhancy-forms/src/lib/form/form-element/form-element.component.ts b/projects/klippa/ngx-enhancy-forms/src/lib/form/form-element/form-element.component.ts
@@ -5,7 +5,7 @@ import {
  ElementRef,
  Inject,
  InjectionToken,
- Input, OnDestroy,
+ Input, NgZone, OnDestroy,
  Optional,
  TemplateRef,
  ViewChild
@@ -69,6 +69,7 @@ export class FormElementComponent implements AfterViewInit, OnDestroy {
  @Optional() private parent: FormComponent,
  @Inject(FORM_ERROR_MESSAGES) @Optional() private customMessages: CustomErrorMessages,
  private elRef: ElementRef,
+ private ngZone: NgZone,
  ) {
  }
 
@@ -123,15 +124,17 @@ export class FormElementComponent implements AfterViewInit, OnDestroy {
  return;
  }
  const containers = [...getAllLimitingContainers(this.elRef.nativeElement), window];
- if (current === 'lockedOpen') {
- containers.forEach(e => {
- e.addEventListener('scroll', this.setErrorTooltipOffset);
- });
- } else {
- containers.forEach(e => {
- e.removeEventListener('scroll', this.setErrorTooltipOffset);
- });
- }
+ this.ngZone.runOutsideAngular(() => {
+ if (current === 'lockedOpen') {
+ containers.forEach(e => {
+ e.addEventListener('scroll', this.setErrorTooltipOffset);
+ });
+ } else {
+ containers.forEach(e => {
+ e.removeEventListener('scroll', this.setErrorTooltipOffset);
+ });
+ }
+ });
  }
 
  public unregisterControl(formControl: UntypedFormControl): void {