Enable NSIS installer for Windows XP

klei1984 · Jul 18, 2024 · f8e89e2 · f8e89e2
1 parent bb78e24
commit f8e89e2
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -176,6 +176,7 @@ jobs:
             cpack --config CPackConfig.cmake
             cpack --config CPackSourceConfig.cmake
             mkdir -p Artifacts/WindowsXP-x86
+            cp *-win32.exe Artifacts/WindowsXP-x86/
             cp *-win32.7z Artifacts/WindowsXP-x86/
             cp *-Source.7z Artifacts/WindowsXP-x86/
             7z a -mx9 -bd max-port-win32-symbols.7z max.debug

diff --git a/cmake/nsis/nsis.cmake b/cmake/nsis/nsis.cmake
@@ -1,4 +1,4 @@
-find_program(MAKENSIS_EXECUTABLE NAMES makensis${CMAKE_EXECUTABLE_SUFFIX} DOC "The NSIS package maker command")
+find_program(MAKENSIS_EXECUTABLE NAMES makensis DOC "The NSIS package maker command")
 if(MAKENSIS_EXECUTABLE)
 	list(APPEND CPACK_GENERATOR "NSIS")
 
@@ -10,7 +10,11 @@ if(MAKENSIS_EXECUTABLE)
 
 	set(CPACK_NSIS_DISPLAY_NAME "M.A.X. Port")
 	set(CPACK_NSIS_PACKAGE_NAME "M.A.X. Port")
-	set(CPACK_NSIS_BRANDING_TEXT " ")
+
+	if(CMAKE_HOST_SYSTEM_NAME STREQUAL "Windows")
+		set(CPACK_NSIS_BRANDING_TEXT " ")
+	endif()
+
 	set(CPACK_NSIS_EXECUTABLES_DIRECTORY ".")
 	set(CPACK_NSIS_MANIFEST_DPI_AWARE TRUE)
 	set(CPACK_NSIS_WELCOME_TITLE_3LINES TRUE)