Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inconsistent implementations of realpath in klee-uclibc #24

Open
wants to merge 1 commit into
base: klee_0_9_29
Choose a base branch
from

Conversation

lipeng28
Copy link

@lipeng28 lipeng28 commented Oct 5, 2018

Hi There

I found there exist some incomplete or unsupported functions in klee-uclibc during my testing with KLEE, I created a simple patch based on current klee-uclibc repo, please check.

  1. Inconsistent implementation with realpath of uclibc
    when I tested programs containing realpath functions, KLEE failed to interpret it correctly, then I found it is caused by obsolete realpath function, so I incorporated the current implementation of realpath in uclibc into klee-uclibc. It works well now.

  2. libc/string/strdup.c does not include __strdup implementation
    When I tested binutils, I found that strdup call will be compiled to __strdup which is interpreted incorrectly by KLEE, so I added the implementation based on Wstrdup.

Thanks
Peng

@ccadar
Copy link
Contributor

ccadar commented Oct 7, 2018

Hi @lipeng28, thanks again for your contribution. Can I ask you two things:
(1) Could you split this into two different PRs, since the two changes are unrelated.
(2) Can you add a test case in each case showing the problem that your change is fixing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants