Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Master] Issue-312 Update ViewedProduct to use incl.tax final price #313

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mamsincl
Copy link

render final price as include tax

Description

#312

Manual Testing Steps

Pre-Submission Checklist:

  • You've updated the CHANGELOG following the steps here
  • Internal Only - If this is a release, please confirm the following:
    • The links in the changelog have been updated to point towards the new versions
    • The version has been incremented in the following places: module.xml and composer.json

NOTE: Please use the Changelogger cli tool to manage versioned file upgrades.

render final price as include tax
@mamsincl mamsincl requested a review from a team as a code owner September 20, 2024 14:01
@mamsincl mamsincl changed the title [Master] Issue-312 Update ViewedProduct.php [Master] Issue-312 Update ViewedProduct to use incl.tax final price Sep 20, 2024
@zchenk zchenk requested a review from smoucka September 20, 2024 14:09
Copy link
Contributor

@smoucka smoucka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mamsincl Thank you for your contribution! This looks good in concept.

Can you please create a new, additive property in the Viewed Product payload, FinalPriceVAT, which contains the final price inclusive of VAT? The current FinalPrice property should stay the same as it is currently.

Please update the CHANGELOG.md with a description of your changes as well.

Thank you!

@mamsincl
Copy link
Author

ideally I'll be able to check this today evening

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants