Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix validation feature #26

Open
wants to merge 5 commits into
base: dev
Choose a base branch
from
Open

Fix validation feature #26

wants to merge 5 commits into from

Conversation

mar-rih
Copy link
Contributor

@mar-rih mar-rih commented May 22, 2024 •
edited
Loading

  • Add a script for validation from the local machine...
  • Enhance the Validation function in the tool to handle the non-existing tables.

@mar-rih mar-rih requested review from MattBlack85 and pawelros May 22, 2024 10:13
@mar-rih mar-rih marked this pull request as ready for review May 22, 2024 10:13
erplsf
erplsf reviewed May 22, 2024
View reviewed changes
Copy link
Member

@erplsf erplsf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so what happens if tables are not the same in the source and target?

@mar-rih
Copy link
Contributor Author

mar-rih commented May 22, 2024

so what happens if tables are not the same in the source and target?

So the migration should be considered and marked as failed?

image

@mar-rih mar-rih requested a review from erplsf May 22, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MattBlack85 MattBlack85 Awaiting requested review from MattBlack85

@pawelros pawelros Awaiting requested review from pawelros

@erplsf erplsf Awaiting requested review from erplsf

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mar-rih @erplsf