Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating dependencies #5

Merged
merged 15 commits into from
Dec 1, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 14 additions & 10 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,26 +7,30 @@ on:

jobs:
check-format:
name: Check format using flutter format
runs-on: ubuntu-latest
container: cirrusci/flutter:stable
name: Check format using dart format.
runs-on: ubuntu-latest

steps:
- name: Checkout code
uses: actions/checkout@v2
- name: Check format
run: flutter format -n --set-exit-if-changed .
steps:
- name: Checkout code
uses: actions/checkout@v2
- name: Flutter Action
uses: subosito/flutter-action@v2
- name: Check format
run: dart format . --set-exit-if-changed

lint:
name: Lint
runs-on: ubuntu-latest
container: cirrusci/flutter:stable

steps:
- name: Checkout code
uses: actions/checkout@v2
- name: Flutter Action
uses: subosito/flutter-action@v2
- name: Install Package Dependencies
run: flutter packages get
- name: Get dependencies for example
run: flutter pub get
working-directory: example
- name: Lint using flutter analyze
run: flutter analyze
run: flutter analyze .
21 changes: 9 additions & 12 deletions analysis_options.yaml
Original file line number Diff line number Diff line change
@@ -1,19 +1,16 @@
#include: package:lint/analysis_options.yaml

analyzer:
include: package:very_good_analysis/analysis_options.yaml

linter:
rules:
close_sinks: true
public_member_api_docs: false
flutter_style_todos: false
avoid_final_parameters: false
sort_constructors_first: false
avoid_classes_with_only_static_members: false
avoid_void_async: false
avoid_positional_boolean_parameters: false
avoid_function_literals_in_foreach_calls: false
avoid_positional_boolean_parameters: false
use_if_null_to_convert_nulls_to_bools: false
use_build_context_synchronously: false
prefer_constructors_over_static_methods: false
sort_unnamed_constructors_first: false
sized_box_for_whitespace: false
use_setters_to_change_properties: false
avoid_print: false
sort_pub_dependencies: false
directives_ordering: false
noop_primitive_operations: false
use_build_context_synchronously: false
28 changes: 0 additions & 28 deletions example/analysis_options.yaml

This file was deleted.

2 changes: 1 addition & 1 deletion example/lib/main.dart
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ class _MyAppState extends State<MyApp> {
}

class _ExampleBody extends StatefulWidget {
const _ExampleBody({super.key});
const _ExampleBody();

@override
State<_ExampleBody> createState() => _ExampleBodyState();
Expand Down
2 changes: 1 addition & 1 deletion example/macos/Flutter/GeneratedPluginRegistrant.swift
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import Foundation

import package_info_plus
import path_provider_foundation
import share_plus_macos
import share_plus
import url_launcher_macos

func RegisterGeneratedPlugins(registry: FlutterPluginRegistry) {
Expand Down
58 changes: 13 additions & 45 deletions example/pubspec.lock
Original file line number Diff line number Diff line change
Expand Up @@ -156,10 +156,10 @@ packages:
dependency: transitive
description:
name: collection
sha256: f092b211a4319e98e5ff58223576de6c2803db36221657b46c82574721240687
sha256: ee67cb0715911d28db6bf4af1026078bd6f0128b07a5f66fb2ed94ec6783c09a
url: "https://pub.dev"
source: hosted
version: "1.17.2"
version: "1.18.0"
convert:
dependency: transitive
description:
Expand Down Expand Up @@ -262,10 +262,10 @@ packages:
dependency: transitive
description:
name: http
sha256: "5895291c13fa8a3bd82e76d5627f69e0d85ca6a30dcac95c4ea19a5d555879c2"
sha256: d4872660c46d929f6b8a9ef4e7a7eff7e49bbf0c4ec3f385ee32df5119175139
url: "https://pub.dev"
source: hosted
version: "0.13.6"
version: "1.1.2"
http_multi_server:
dependency: transitive
description:
Expand Down Expand Up @@ -334,10 +334,10 @@ packages:
dependency: transitive
description:
name: meta
sha256: "3c74dbf8763d36539f114c799d8a2d87343b5067e9d796ca22b5eb8437090ee3"
sha256: a6e590c838b18133bb482a2745ad77c5bb7715fb0451209e1a7567d416678b8e
url: "https://pub.dev"
source: hosted
version: "1.9.1"
version: "1.10.0"
mime:
dependency: transitive
description:
Expand Down Expand Up @@ -486,50 +486,18 @@ packages:
dependency: transitive
description:
name: share_plus
sha256: f582d5741930f3ad1bf0211d358eddc0508cc346e5b4b248bd1e569c995ebb7a
url: "https://pub.dev"
source: hosted
version: "4.5.3"
share_plus_linux:
dependency: transitive
description:
name: share_plus_linux
sha256: dc32bf9f1151b9864bb86a997c61a487967a08f2e0b4feaa9a10538712224da4
sha256: f74fc3f1cbd99f39760182e176802f693fa0ec9625c045561cfad54681ea93dd
url: "https://pub.dev"
source: hosted
version: "3.0.1"
share_plus_macos:
dependency: transitive
description:
name: share_plus_macos
sha256: "44daa946f2845045ecd7abb3569b61cd9a55ae9cc4cbec9895b2067b270697ae"
url: "https://pub.dev"
source: hosted
version: "3.0.1"
version: "7.2.1"
share_plus_platform_interface:
dependency: transitive
description:
name: share_plus_platform_interface
sha256: "0c6e61471bd71b04a138b8b588fa388e66d8b005e6f2deda63371c5c505a0981"
url: "https://pub.dev"
source: hosted
version: "3.2.1"
share_plus_web:
dependency: transitive
description:
name: share_plus_web
sha256: eaef05fa8548b372253e772837dd1fbe4ce3aca30ea330765c945d7d4f7c9935
url: "https://pub.dev"
source: hosted
version: "3.1.0"
share_plus_windows:
dependency: transitive
description:
name: share_plus_windows
sha256: "3a21515ae7d46988d42130cd53294849e280a5de6ace24bae6912a1bffd757d4"
sha256: df08bc3a07d01f5ea47b45d03ffcba1fa9cd5370fb44b3f38c70e42cced0f956
url: "https://pub.dev"
source: hosted
version: "3.0.1"
version: "3.3.1"
shelf:
dependency: transitive
description:
Expand Down Expand Up @@ -723,10 +691,10 @@ packages:
dependency: transitive
description:
name: web
sha256: dc8ccd225a2005c1be616fe02951e2e342092edf968cf0844220383757ef8f10
sha256: afe077240a270dcfd2aafe77602b4113645af95d0ad31128cc02bce5ac5d5152
url: "https://pub.dev"
source: hosted
version: "0.1.4-beta"
version: "0.3.0"
web_socket_channel:
dependency: transitive
description:
Expand Down Expand Up @@ -760,5 +728,5 @@ packages:
source: hosted
version: "3.1.2"
sdks:
dart: ">=3.1.0-185.0.dev <4.0.0"
dart: ">=3.2.0 <4.0.0"
flutter: ">=3.3.0"
2 changes: 1 addition & 1 deletion example/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ description: Demonstrates how to use the Alice plugin.
publish_to: "none"

environment:
sdk: ">=2.17.6 <3.0.0"
sdk: ^3.0.0

dependencies:
flutter:
Expand Down
3 changes: 3 additions & 0 deletions example/windows/flutter/generated_plugin_registrant.cc
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,12 @@

#include "generated_plugin_registrant.h"

#include <share_plus/share_plus_windows_plugin_c_api.h>
#include <url_launcher_windows/url_launcher_windows.h>

void RegisterPlugins(flutter::PluginRegistry* registry) {
SharePlusWindowsPluginCApiRegisterWithRegistrar(
registry->GetRegistrarForPlugin("SharePlusWindowsPluginCApi"));
UrlLauncherWindowsRegisterWithRegistrar(
registry->GetRegistrarForPlugin("UrlLauncherWindows"));
}
1 change: 1 addition & 0 deletions example/windows/flutter/generated_plugins.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
#

list(APPEND FLUTTER_PLUGIN_LIST
share_plus
url_launcher_windows
)

Expand Down
4 changes: 2 additions & 2 deletions lib/alice.dart
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
export 'package:alice/src/model/alice_log.dart';
export 'package:alice/src/alice.dart';
export 'package:alice/src/core/alice_core.dart';
export 'package:alice/src/core/http/alice_http_extensions.dart';
export 'package:alice/src/core/http_client/alice_http_client_extensions.dart';
export 'package:alice/src/core/http/alice_http_extensions.dart';
export 'package:alice/src/model/alice_log.dart';
3 changes: 2 additions & 1 deletion lib/src/alice.dart
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,8 @@ class Alice {
///method queue will be used to remove elements.
final int maxCallsCount;

///Directionality of app. Directionality of the app will be used if set to null.
///Directionality of app. Directionality of the app will be used if set to
/// null.
final TextDirection? directionality;

///Flag used to show/hide share button
Expand Down
9 changes: 5 additions & 4 deletions lib/src/core/alice_core.dart
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
// ignore_for_file: cascade_invocations
import 'dart:async';

import 'package:alice/src/core/alice_logger.dart';
Expand Down Expand Up @@ -32,7 +33,7 @@ class AliceCore {

final Brightness _brightness;
bool _isInspectorOpened = false;
StreamSubscription? _callsSubscription;
StreamSubscription<dynamic>? _callsSubscription;

/// Creates alice core instance
AliceCore({
Expand Down Expand Up @@ -88,7 +89,7 @@ class AliceCore {
final selectedCall = _selectCall(requestId);

if (selectedCall == null) {
debugPrint("Selected call is null");
debugPrint('Selected call is null');
return;
}

Expand All @@ -100,10 +101,10 @@ class AliceCore {

/// Add response to existing alice http call
void addResponse(AliceHttpResponse response, Object requestId) {
final AliceHttpCall? selectedCall = _selectCall(requestId);
final selectedCall = _selectCall(requestId);

if (selectedCall == null) {
debugPrint("Selected call is null");
debugPrint('Selected call is null');
return;
}
selectedCall.loading = false;
Expand Down
5 changes: 3 additions & 2 deletions lib/src/core/alice_logger.dart
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,8 @@ class AliceLogger {

/// The maximum number of logs to store or `null` for unlimited storage.
///
/// If more logs arrive, the oldest ones (based on their [AliceLog.timestamp]) will
/// If more logs arrive, the oldest ones (based on their [AliceLog.timestamp])
/// will
/// be removed.
int? get maximumSize => _maximumSize;

Expand Down Expand Up @@ -46,7 +47,7 @@ class AliceLogger {
min = mid + 1;
}
}
assert(min == max);
assert(min == max, 'Invalid');
index = min;
}

Expand Down
Loading
Loading