-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[KGA-29] [KGA-136] fix: cases with Cairo precompiles and delegatecalls #1567
Conversation
6fe6ce4
to
5ee817b
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1567 +/- ##
=====================================
Coverage 63.6% 63.6%
=====================================
Files 44 44
Lines 8343 8341 -2
=====================================
+ Hits 5309 5313 +4
+ Misses 3034 3028 -6 ☔ View full report in Codecov by Sentry. |
94f8c6d
to
7d316cd
Compare
7d316cd
to
2e14113
Compare
tests/end_to_end/CairoPrecompiles/test_call_cairo_precompile.py
Outdated
Show resolved
Hide resolved
All relevant end to end tests passes but there is problems with relayers cc @ClementWalter |
address) and only register succeeded cairo call in message
9596703
to
78e4ab3
Compare
Co-authored-by: Mathieu <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok for me, I was a bit surprised in the beginning in the tests/end_to_end/NoDelegateCall/test_dual_vm_token_hack.py
test that the test was failing with and without the modifier, but it's because we also did the modif in cairo to remediate the issue
Fixes the issue raised during the audit about eventual honeypots that could lure a user and manipulate starknet tokens without explicit approvals
code_address
for whitelisting, which were reported dangerous.Security/
https://github.com/code-423n4/2024-09-kakarot-findings/issues/38
https://github.com/code-423n4/2024-09-kakarot-findings/issues/124
Closes #1562
This change is