Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: cache code_hash #930

Merged
merged 1 commit into from
Sep 12, 2024
Merged

Conversation

obatirou
Copy link
Contributor

@obatirou obatirou commented Sep 12, 2024

Pull Request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Resolves: #840

What is the new behavior?

Code hash cache in storage

Does this introduce a breaking change?

  • Yes
  • No

This change is Reviewable

@obatirou obatirou marked this pull request as ready for review September 12, 2024 09:25
Copy link
Collaborator

@enitrat enitrat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, however the devX regarding mocking calls in tests looks a bit bad - can we identify common patterns (like what calls do we need to constantly mock) and add a helper function ?

We can make a new issue for that

@obatirou
Copy link
Contributor Author

obatirou commented Sep 12, 2024

lgtm, however the devX regarding mocking calls in tests looks a bit bad - can we identify common patterns (like what calls do we need to constantly mock) and add a helper function ?

We can make a new issue for that

Indeed
Created an issue for this #931
Merging the current PR

@obatirou obatirou added this pull request to the merge queue Sep 12, 2024
Merged via the queue into kkrt-labs:main with commit f14fd32 Sep 12, 2024
3 checks passed
@obatirou obatirou deleted the store-codehash-storage branch September 12, 2024 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: store codehash upon deployment and read codehash from storage in fetch_or_create
2 participants