Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Typographical Error Update compute_resources.py #779

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mdqst
Copy link

@mdqst mdqst commented Nov 19, 2024

Summary of Change:
This pull request addresses a small typographical error in the regular expression pattern within the get_resource_usage function.

Original Code:

r"ef_testing::models::result: (.*) passed: .?ResourcesMapping\((.*)\)"

Corrected Code:

r"ef_testing::models::result: (.*) passed: ResourcesMapping\((.*)\)"

Reason for Change:
The dot (.) in the original regular expression .?ResourcesMapping is unnecessary and likely a typo. It matches zero or one character before the ResourcesMapping text, which could cause incorrect matches. The intended pattern should directly match "passed:" followed by ResourcesMapping, without allowing any characters in between. Removing the dot ensures that the pattern matches the exact string "passed: ResourcesMapping" correctly.

Impact:
This change is important because it ensures the regular expression behaves as expected, leading to more accurate parsing of the output. Without this correction, the regular expression could match unwanted results or fail to properly capture the intended data, potentially leading to issues in further processing or inaccurate results.


Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Testing

Does this introduce a breaking change?

  • Yes
  • No

This pull request addresses a small typographical error in the regular expression pattern within the get_resource_usage function.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant