Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor/result pattern refactor #9

Merged
merged 3 commits into from
Sep 24, 2023
Merged

Refactor/result pattern refactor #9

merged 3 commits into from
Sep 24, 2023

Conversation

Eikix
Copy link
Member

@Eikix Eikix commented Sep 23, 2023

No description provided.

@Eikix Eikix requested a review from greged93 September 23, 2023 10:13
greged93
greged93 reviewed Sep 23, 2023
View reviewed changes
Copy link
Contributor

@greged93 greged93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love this PR, making ts more like rust!

src/result-pattern/result.ts Show resolved Hide resolved
src/memory/memory.ts Show resolved Hide resolved
src/memory/memory.ts Outdated Show resolved Hide resolved
src/memory/memory.ts Outdated Show resolved Hide resolved
greged93
greged93 approved these changes Sep 24, 2023
View reviewed changes
Copy link
Contributor

@greged93 greged93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@greged93 greged93 merged commit c653532 into main Sep 24, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greged93 greged93 greged93 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Eikix @greged93