fix: memory management #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greged93
requested review from
ClementWalter and
Eikix
and removed request for
ClementWalter
Eikix
reviewed
Sep 23, 2023
Eikix
reviewed
Sep 23, 2023
| class MemorySegmentManager { | ||
| segmentSizes: Record<number, number>; | ||
| export class MemorySegmentManager { | ||
| segmentSizes: Record<Uint, Uint>; |
There was a problem hiding this comment.
In general:
If you have a static set of keys or you want a type that behaves like a regular object but with type safety, Record is a good choice.
If you want a dynamic collection of key-value pairs with more utility methods and insertion order, then Map is the way to go.
Lastly, considering the branding on Uint, if you were to use the Record, keep in mind that object keys in JavaScript are always strings, so there might be some nuances with key conversion if you try to use the branded number directly as a key.
Eikix
reviewed
Sep 23, 2023
Eikix
reviewed
Sep 23, 2023
Eikix
reviewed
Sep 23, 2023
| @@ -41,7 +41,7 @@ export class Felt { | |||
| } | |||
|
|
|||
| toNumber(): number { | |||
| let num = Number(this.inner); | |||
| const num = Number(this.inner); | |||
Eikix
approved these changes
Sep 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes couple of issues in the memory, typos and adds couple of tests for the Memory.