New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmsis_dap improvements. #18

Merged

kkitayam merged 1 commit into kkitayam:main from HiFiPhile:cmsis-dap

Sep 2, 2024

Contributor

HiFiPhile commented Sep 1, 2024

Hi, thanks for your probe, I made an implementation on LPC55.

I made some improvements to the class in case if you are interested:

Use usbd_edpt_claim for concurrent locking.
Add dedicated SWO EP support (not seriously tested)
Use uint8_t occupancy, since int promotion will make wrong calculation if wp is wrapped
Use weak default for callback


          cmsis_dap improvements.

d86fc88

Owner

kkitayam commented Sep 2, 2024

Thank you for your PR!

Use usbd_edpt_claim for concurrent locking.

The improvement is excellent! It seems I didn’t notice the API at that time.

kkitayam merged commit fe65621 into kkitayam:main

1 check failed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet