Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added an automated Selenium UI test for a small Zimit2 archive #1286
base: main
Are you sure you want to change the base?
Added an automated Selenium UI test for a small Zimit2 archive #1286
Changes from 17 commits
6859ab9
f1c5ec1
66aeef5
badde6f
b8543f0
f0b17ae
3cfc527
92727c3
f7916ca
ec085d0
cb7f22b
1bc38fd
d381a37
db01d15
5a6b02f
f349db4
f2ebf5f
cb14eef
1e5e6dd
5a53ffe
06c33dc
088e354
1ce071d
125bbc1
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be better just to say "Navigate from ...." (without "Should").
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rather than using console.log here, make this into a test and assert that
androidLink !== null
. If it is null, then the test would fail. The formatting would be better in the log too.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Problem with this is that it's impossible to see screenshots in GitHub Actions AFAIK!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we have videos taken on BrowserStack, I think this screenshotting probably isn't necessary. Best to remove it.