Add i189 for Chromium store entries #1271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jaifroid
added
the
extensions
|
Thanks, I'm going to see if I can do a test draft upload from this branch to the Edge Store to see if this actually does the job I want it to do... |
|
Hmm, something is wrong uploading and zipping the _locales directory. I'll debug tomorrow. |
|
LOL, I forgot to add the |
|
Yay, it works, finally!
Now I just have to work out why the "Description" field is empty when I thought included it.... |
|
OK, so description in Edge Store at least isn't taken from the manifest, so I think this PR is complete now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1118. According to the messages I receive when uploading an extension to the Edge or Chrome Stores, in order to internationalize the Store entry it is necessary to internationalize the manifests, adding those languages supported by the app. I've followed https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/Internationalization, but I don't know for sure that this will do the trick until I attempt to upload the generated extension ZIPs.
We don't use the Chrome i18n module for i18n within the app, as we use a much simpler string-substitution system, and I'm not going to change that any time soon, especially as i18n for this app needs to work in multiple contexts, not just extensions.