Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for Android 15. #4147

Merged
merged 22 commits into from
Jan 3, 2025
Merged

Added support for Android 15. #4147

merged 22 commits into from
Jan 3, 2025

Conversation

MohitMaliFtechiz
Copy link
Collaborator

@MohitMaliFtechiz MohitMaliFtechiz commented Dec 20, 2024

Fixes #3990

  • Updated Gradle and kotlin versions.
  • Updated related dependency to their latest version.
  • Added kotlin-ksp in the project since gradle 2.0+ needs ksp instead of kapt.
  • Upgraded the dagger version to 2.53.1.
  • Upgraded the ksp version to 2.0.0-1.0.24.
  • Upgraded the kotlin version to 2.0.0.
  • Upgraded the objectbox version to 4.0.3.
  • Removed the deprecated runBlockingTest from test cases which was giving compilation errors because it is permanently removed in this version of kotlin.
  • Replaced some deprecated methods with new methods that are deprecated in the latest version of Gradle.
  • Fixed some string lint issues.
  • Enabled EdgeToEdge mode in the project to support the latest windowInset API.
  • Fixed: The recyclerview content was overlapping on the status bar.
  • Improved the full-screen mode, as the systemBars(3 buttons at the bottom) were visible in full-screen mode.
  • Added backward compatibility for edgeToEdge mode to support all Android versions.
  • Added Android 15 emualtor in CI to run test cases on it.

@MohitMaliFtechiz MohitMaliFtechiz marked this pull request as draft December 20, 2024 13:28
@MohitMaliFtechiz MohitMaliFtechiz force-pushed the Fixes#3990 branch 2 times, most recently from 7be4a11 to 5cf5f61 Compare January 2, 2025 12:00
Copy link

codecov bot commented Jan 2, 2025

Codecov Report

Attention: Patch coverage is 55.93220% with 26 lines in your changes missing coverage. Please review.

Project coverage is 56.98%. Comparing base (061249a) to head (cd6d5e2).
Report is 23 commits behind head on main.

Files with missing lines Patch % Lines
.../kiwixmobile/core/extensions/FragmentExtensions.kt 25.00% 8 Missing and 1 partial ⚠️
.../org/kiwix/kiwixmobile/core/error/ErrorActivity.kt 0.00% 4 Missing ⚠️
...iwix/kiwixmobile/core/extensions/ViewExtensions.kt 77.77% 3 Missing and 1 partial ⚠️
...rc/main/java/org/kiwix/kiwixmobile/core/CoreApp.kt 0.00% 1 Missing and 1 partial ⚠️
...va/org/kiwix/kiwixmobile/core/base/BaseActivity.kt 60.00% 1 Missing and 1 partial ⚠️
...va/org/kiwix/kiwixmobile/core/base/BaseFragment.kt 33.33% 1 Missing and 1 partial ⚠️
.../kiwixmobile/core/extensions/ActivityExtensions.kt 0.00% 2 Missing ⚠️
...wix/kiwixmobile/core/utils/SharedPreferenceUtil.kt 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##               main    #4147   +/-   ##
=========================================
  Coverage     56.98%   56.98%           
- Complexity     1517     1519    +2     
=========================================
  Files           313      313           
  Lines         13373    13399   +26     
  Branches       1655     1662    +7     
=========================================
+ Hits           7620     7636   +16     
- Misses         4604     4613    +9     
- Partials       1149     1150    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MohitMaliFtechiz MohitMaliFtechiz marked this pull request as ready for review January 3, 2025 12:34
* Upgraded the ksp version to `2.0.0-1.0.24`.
* Upgraded the kotlin version to `2.0.0`.
* Upgraded the objectbox version to `4.0.3`.
* Removed the deprecated `runBlockingTest` from test cases which was giving compilation error because it is permanently removed in this version of kotlin.
* Replaced some deprecated methods with new methods that is deprecated in latest version of gradle.
* Fixed some string lint issues.
* Upgraded the `kotlin_coroutines` dependency to `1.10.1`.
* Upgraded the `espresso` dependency to `3.6.1`.
* Upgraded the `tracing` dependency to `1.2.0`.
* Upgraded the `espresso` dependency to `3.6.1`.
* Upgraded the `material` dependency to `1.12.0`.
* Upgraded the `webkit` dependency to `1.12.1`.
* Upgraded the `room` dependency to `2.6.1`.
…id versions.

* Removed the deprecated `FLAG_FULLSCREEN` from our project.
…nd above devices.

* Added proper comments on methods why we are doing this.
* It was showing the content behind the display cutout in landscape mode.
* Removed the unnecessary code from BaseFragment.
* Enhanced the applying edge to edge mode for lower devices(Before Android 10).
@kelson42 kelson42 merged commit 359a1fc into main Jan 3, 2025
28 checks passed
@kelson42 kelson42 deleted the Fixes#3990 branch January 3, 2025 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Android 15
3 participants