#4083 fixed external link warning when user wants to make a donation

[viditpawar0]

Fixes #4083

Fixed external link warning when user wants to make a donation

[MohitMaliFtechiz]

@viditpawar0 We have the DonationPopup functionality as well which we have recently added, which shows on the reader screen. So when the user clicks on the "Make a donation" button this method calls

kiwix-android/core/src/main/java/org/kiwix/kiwixmobile/core/main/CoreReaderFragment.kt

Line 1676 in 9fc6e66

override fun openExternalUrl(intent: Intent) {

According to your existing code, it will work fine with the Kiwix app, but for custom apps, we have overrided this method in CustomReaderFragment to make custom behavior according to configuration. So we have to make the changes there as well so that when while user clicks on the donation button in custom apps this popup will not show.

Apart from these changes: The test cases are falling due to this change specially topLevelDestinationTest so can you please fix that?

[viditpawar0]

Sure, I'll do that.
I'm not sure about the topLevelDestinationTest though.

[viditpawar0]

All the requested changes have been done.

Summary: -

• made the same fix for custom apps in CustomMainActivity
• modified topLevelDestinationTest
• fixed the same for CoreReaderFragment and CustomReaderFragment

[MohitMaliFtechiz]

@viditpawar0 Thanks for making the changes. Please see comments.

[viditpawar0]

Okay, made the required changes

[MohitMaliFtechiz]

@viditpawar0 Thanks for making the changes. @kelson42 LGTM.