-
-
Notifications
You must be signed in to change notification settings - Fork 459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed the Hotspot
feature from custom apps, and used the normal service instead of foreground service for readAloud
feature.
#4027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MohitMaliFtechiz
force-pushed
the
Fixes#4026
branch
from
October 10, 2024 10:03
6a9cce2
to
0e81f7e
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4027 +/- ##
============================================
- Coverage 58.32% 58.08% -0.24%
+ Complexity 1601 1505 -96
============================================
Files 314 315 +1
Lines 13024 13020 -4
Branches 1656 1657 +1
============================================
- Hits 7596 7563 -33
- Misses 4321 4354 +33
+ Partials 1107 1103 -4 ☔ View full report in Codecov by Sentry. |
MohitMaliFtechiz
changed the title
Fixed: "Publish App to playStore" task failed to upload the application on PlayStore.
Removed the Oct 11, 2024
Hotspot
feature from custom apps.
MohitMaliFtechiz
force-pushed
the
Fixes#4026
branch
from
October 11, 2024 12:20
a180bad
to
9bcf1f3
Compare
…adAloud` feature. * Since the `readAloud` feature only runs when the reader screen is active if we move to another screen, or close the application then `readAloud` stops so we do not need to use the foreground service for this.
MohitMaliFtechiz
changed the title
Removed the
Removed the Oct 18, 2024
Hotspot
feature from custom apps.Hotspot
feature from custom apps, and used the normal service instead of foreground service for readAloud
feature.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parent Issue #4026
Fixes #4041
Now we are using normal service instead of foreground service for the
readAloud
feature.readAloud
feature only runs when the reader screen is active if we move to another screen, or close the application thenreadAloud
stops so we do not need to use the foreground service for this.BeforeFix.mp4
AfterFix.mp4