Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed the Hotspot feature from custom apps, and used the normal service instead of foreground service for readAloud feature. #4027

Merged
merged 8 commits into from
Oct 18, 2024

Conversation

MohitMaliFtechiz
Copy link
Collaborator

@MohitMaliFtechiz MohitMaliFtechiz commented Oct 10, 2024

Parent Issue #4026

  • Removed the Hotspot feature from the custom app. Since currently this feature is hidden in the custom apps so when we will upload the custom apps on playStore it can cause rejection. So for now, we have just removed this feature and permission from custom apps.

Fixes #4041
Now we are using normal service instead of foreground service for the readAloud feature.

  • Since the readAloud feature only runs when the reader screen is active if we move to another screen, or close the application then readAloud stops so we do not need to use the foreground service for this.
Before (With foreground service) After (With normal service)
BeforeFix.mp4
AfterFix.mp4

Copy link

codecov bot commented Oct 11, 2024

Codecov Report

Attention: Patch coverage is 75.86207% with 7 lines in your changes missing coverage. Please review.

Project coverage is 58.08%. Comparing base (bad8f4c) to head (f32d0d6).
Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
...ile/core/read_aloud/ReadAloudNotificationManger.kt 0.00% 2 Missing ⚠️
...ix/kiwixmobile/core/read_aloud/ReadAloudService.kt 0.00% 2 Missing ⚠️
...iwix/kiwixmobile/di/modules/KiwixActivityModule.kt 0.00% 1 Missing ⚠️
.../org/kiwix/kiwixmobile/di/modules/ServiceModule.kt 88.88% 1 Missing ⚠️
...ile/nav/destination/library/CopyMoveFileHandler.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #4027      +/-   ##
============================================
- Coverage     58.32%   58.08%   -0.24%     
+ Complexity     1601     1505      -96     
============================================
  Files           314      315       +1     
  Lines         13024    13020       -4     
  Branches       1656     1657       +1     
============================================
- Hits           7596     7563      -33     
- Misses         4321     4354      +33     
+ Partials       1107     1103       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MohitMaliFtechiz MohitMaliFtechiz changed the title Fixed: "Publish App to playStore" task failed to upload the application on PlayStore. Removed the Hotspot feature from custom apps. Oct 11, 2024
@MohitMaliFtechiz MohitMaliFtechiz marked this pull request as ready for review October 11, 2024 12:49
@MohitMaliFtechiz MohitMaliFtechiz marked this pull request as draft October 18, 2024 04:40
…adAloud` feature.

* Since the `readAloud` feature only runs when the reader screen is active if we move to another screen, or close the application then `readAloud` stops so we do not need to use the foreground service for this.
@MohitMaliFtechiz MohitMaliFtechiz marked this pull request as ready for review October 18, 2024 06:42
@MohitMaliFtechiz MohitMaliFtechiz changed the title Removed the Hotspot feature from custom apps. Removed the Hotspot feature from custom apps, and used the normal service instead of foreground service for readAloud feature. Oct 18, 2024
@kelson42 kelson42 merged commit f307700 into main Oct 18, 2024
22 checks passed
@kelson42 kelson42 deleted the Fixes#4026 branch October 18, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stop using foreground service for Read Aloud feature.
3 participants