Fixed: Mul file not recognized as such and listing pretty much all languages.

[MohitMaliFtechiz]

Fixes #3892

Showing zim files in all available languages.

screen-20240715-143816.mp4

[kelson42]

There should not be a multilanguage category, the ZIM should appear as in English or French etc... An visually we should have a way to list, in the book description that this is a multilanguage book. Please make a clear proposal before coding. You should take example in library.kiwix.org.

[codecov]

Codecov Report

Attention: Patch coverage is 16.66667% with 35 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@48efdfa). Learn more about missing BASE report.

Files	Patch %	Lines
...ix/kiwixmobile/core/entity/LibraryNetworkEntity.kt	0.00%	32 Missing ⚠️
...java/org/kiwix/kiwixmobile/core/data/Repository.kt	70.00%	2 Missing and 1 partial ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #3915   +/-   ##
=======================================
  Coverage        ?   53.32%           
  Complexity      ?     1409           
=======================================
  Files           ?      303           
  Lines           ?    11749           
  Branches        ?     1553           
=======================================
  Hits            ?     6265           
  Misses          ?     4477           
  Partials        ?     1007           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[MohitMaliFtechiz]

@kelson42 It is showing under the mul language on library.kiwix.org.

and also the book has multiple language tags.

Also, I have the ted_mul_crowdsourcing_2024-03.zim which was showing under the "Multiple languages" since it has the mul language code.

screen-20240701-121744.mp4

So due to these things, I thought it should show under the "Multiple languages".

the ZIM should appear as in English or French etc...

We have a language code like this in this book (eng,fra,vie,ita,ara,por), we can list this type of book under the first language code that comes in the language tag. So it is better to list this type of book in the English language(Since the default articles are also shown in the English language in this zim file).

An visually we should have a way to list, in the book des ription that this is a multilanguage book.

@kelson42 I was thinking about this, and IMO we should show that this is a multiple-language book in tags instead of the book description. Since we are showing that this book has (picture, video, short text, etc) it shows the main information about the book, and if we show "Multiple languages" as a tag it will highlight to the user, and the user can easily know that this book is a multi-language book.

There should not be a multilanguage category,

Also, we can do the same with the mul language code books as they are currently showing under the "Multiple languages" category as shown in the above video. We can do the same for those zim files so that no "Multiple languages" category will be displayed on the library screen. @kelson42 What do you think?

[kelson42]

@kelson42 It is showing under the mul language on library.kiwix.org.

Sorry for misguiding you actually. This is a bug there, see kiwix/libkiwix#1098

... but this is an heritage of the past, the ZIM languages are ordered properly in each language supported. See here for example:
https://library.kiwix.org/#q=anthropocene&lang=deu&category=ted

[kelson42]

An visually we should have a way to list, in the book des ription that this is a multilanguage book.

@kelson42 I was thinking about this, and IMO we should show that this is a multiple-language book in tags instead of the book description. Since we are showing that this book has (picture, video, short text, etc) it shows the main information about the book, and if we show "Multiple languages" as a tag it will highlight to the user, and the user can easily know that this book is a multi-language book.

There should not be a multilanguage category,

Also, we can do the same with the mul language code books as they are currently showing under the "Multiple languages" category as shown in the above video. We can do the same for those zim files so that no "Multiple languages" category will be displayed on the library screen. @kelson42 What do you think?

@MohitMaliDeveloper What you say makes sense and I agree with many parts of your proposal. But the solution of this problem will be in many places:

• For the moment, in this issue, just list the book in each of the languages listed. We will give up on the visual as this is a non trivial thing tomdo.
• Then we have actually an other problem which is that here the other languages are subtitles and there is no clear way to understand that (for the user). We will fix that we other metadata, see Better advertise the languages present in a ZIM openzim/overview#38
• Finally, in term of result displaying. In the future we will have to implement a way to provide many groups. for example first the full language match, the books which have only a few content in this language, then maybe book with subtitles in this language, etc... kind of extension of this feature for kiwix-serve If no ZIM found for a language then automatically make the search with other languages (kiwix-serve) kiwix-tools#562

So can you please just implement the first part so we can merge?

[MohitMaliFtechiz]

For the moment, in this issue, just list the book in each of the languages listed. We will give up on the visual as this is a non trivial thing tomdo.

@kelson42 I have made the changes according to your request and updated the video on PR description for visual reference.