Merge pull request #3918 from kiwix/Fixes#3912

Fixed: latency in showing whether a bookmark is added in the toggle button.
kiwix · Jul 1, 2024 · 3c0397d · 3c0397d
2 parents ad9e7e6 + 5f9ef86
commit 3c0397d
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/core/src/main/java/org/kiwix/kiwixmobile/core/main/CoreReaderFragment.kt b/core/src/main/java/org/kiwix/kiwixmobile/core/main/CoreReaderFragment.kt
@@ -2116,7 +2116,6 @@ abstract class CoreReaderFragment :
       }
       updateTableOfContents()
       tabsAdapter?.notifyDataSetChanged()
-      updateUrlProcessor()
       updateBottomToolbarArrowsAlpha()
       val zimFileReader = zimReaderContainer?.zimFileReader
       if (hasValidFileAndUrl(getCurrentWebView()?.url, zimFileReader)) {
@@ -2150,13 +2149,18 @@ abstract class CoreReaderFragment :
 
   override fun webViewFailedLoading(url: String) {
     if (isAdded) {
+      // If a URL fails to load, update the bookmark toggle.
+      // This fixes the scenario where the previous page is bookmarked and the next
+      // page fails to load, ensuring the bookmark toggle is unset correctly.
+      updateUrlProcessor()
       Log.d(TAG_KIWIX, String.format(getString(R.string.error_article_url_not_found), url))
     }
   }
 
   @Suppress("MagicNumber")
   override fun webViewProgressChanged(progress: Int, webView: WebView) {
     if (isAdded) {
+      updateUrlProcessor()
       progressBar?.apply {
         visibility = View.VISIBLE
         show()