Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added support for web platform #1

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

added support for web platform #1

wants to merge 2 commits into from

Conversation

melWiss
Copy link

@melWiss melWiss commented Jan 9, 2023

No description provided.

jaumard
jaumard suggested changes Jan 9, 2023
View reviewed changes
Copy link
Contributor

@jaumard jaumard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, Thanks for the PR! There is a lot of formatting changes, can you set your line length to 160 please to avoid those changes.

I didn't notice the . files were on git, I'll remove them later.

@melWiss
Copy link
Author

melWiss commented Jan 9, 2023

okay I'll do some refactoring

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaumard jaumard jaumard requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@melWiss @jaumard