Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow use of return_maps in options #28

Merged
merged 1 commit into from
Dec 23, 2021
Merged

Conversation

cdyb-kivra
Copy link
Contributor

Make it so that giving the return_maps option does not crash.

@maxno-kivra
Copy link
Member

maxno-kivra commented Dec 16, 2021

I couldn't do an inline suggestion, so I made another branch/PR. That one switches to use maps instead. What do you think?

@cdyb-kivra
Copy link
Contributor Author

I couldn't do an inline suggestion, so I made another branch/PR. That one switches to use maps instead. What do you think?

It also solves the problem. Not sure if it really makes things noticeably better, but I don't mind going with it. Is there a reason that this call needs to use the payload's options at all, by the way? I couldn't think of one.

@maxno-kivra
Copy link
Member

Is there a reason that this call needs to use the payload's options at all, by the way? I couldn't think of one.

What is "the payload's option" here? 😕

@cdyb-kivra
Copy link
Contributor Author

What is "the payload's option" here? 😕

Options meant for calls to the API being talked to rather than for calls that are part of the OAuth2 flow.

@cdyb-kivra cdyb-kivra merged commit 47ba50a into master Dec 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants