Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat:add consul && client && server &&config watch #1

Merged
merged 27 commits into from
Jan 21, 2024
Merged

feat:add consul && client && server &&config watch #1

merged 27 commits into from
Jan 21, 2024

Conversation

hiahia12
Copy link
Collaborator

@hiahia12 hiahia12 commented Jan 2, 2024

What type of PR is this?

feat

Check the PR title.

feat:add consul && client && server &&config watch

(Optional) Translate the PR title into Chinese.

增加consul初始化连接，client端和server端，配置监视

@felix021 felix021 assigned li-jin-gou and unassigned felix021 Jan 3, 2024
@felix021
Copy link
Contributor

felix021 commented Jan 3, 2024

  1. 看起来依赖的库不支持旧版本的 go，可以改下 /.github/workflows/tests.yml，去掉不支持的版本
  2. lint 和 staticcheck 里的问题也需要修一下哈

@hiahia12
Copy link
Collaborator Author

hiahia12 commented Jan 3, 2024

  1. 看起来依赖的库不支持旧版本的 go，可以改下 /.github/workflows/tests.yml，去掉不支持的版本
  2. lint 和 staticcheck 里的问题也需要修一下哈

好的，这周末或者下周末我会尽快搞掉...

ViolaPioggia
ViolaPioggia reviewed Jan 17, 2024
View reviewed changes
client/retry.go Outdated Show resolved Hide resolved
ViolaPioggia
ViolaPioggia reviewed Jan 17, 2024
View reviewed changes
consul/consul.go Outdated Show resolved Hide resolved
ViolaPioggia
ViolaPioggia reviewed Jan 17, 2024
View reviewed changes
consul/parser.go Outdated Show resolved Hide resolved
ViolaPioggia
ViolaPioggia reviewed Jan 17, 2024
View reviewed changes
Copy link

@ViolaPioggia ViolaPioggia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

有在本地进行过测试吗？

@hiahia12
Copy link
Collaborator Author

有在本地进行过测试吗？

应该算是测过的..是有发现什么怪怪问题吗

@ViolaPioggia
Copy link

应该算是测过的..是有发现什么怪怪问题吗

暂时没有问题，只要本地能够获取到配置信息以及监听到配置变化基本就OK

li-jin-gou
li-jin-gou reviewed Jan 17, 2024
View reviewed changes
consul/parser.go Outdated Show resolved Hide resolved
@ViolaPioggia
Copy link

在本地键值对为空的情况下会出现以下问题：
1，server 端获取的配置为空的时候不应该出现 unmarshal failed 的报错，应该采取默认配置进行设置
2，client 端直接 panic
image

@ViolaPioggia
Copy link

在本地键值对为空的情况下会出现以下问题： 1，server 端获取的配置为空的时候不应该出现 unmarshal failed 的报错，应该采取默认配置进行设置 2，client 端直接 panic

image

@hiahia12
Copy link
Collaborator Author

在本地键值对为空的情况下会出现以下问题： 1，server 端获取的配置为空的时候不应该出现 unmarshal failed 的报错，应该采取默认配置进行设置 2，client 端直接 panic

image

稍晚几天，这几天我抽空解决一下

@hiahia12
Copy link
Collaborator Author

在本地键值对为空的情况下会出现以下问题： 1，server 端获取的配置为空的时候不应该出现 unmarshal failed 的报错，应该采取默认配置进行设置 2，client 端直接 panic

image

我感觉好像大概是处理掉了，你再帮忙瞅两眼。。？

@bytedance-oss-robot bytedance-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: hiahia12, li-jin-gou

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@li-jin-gou li-jin-gou merged commit 7841251 into kitex-contrib:main Jan 21, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ViolaPioggia ViolaPioggia ViolaPioggia left review comments

@li-jin-gou li-jin-gou li-jin-gou approved these changes

Assignees

@li-jin-gou li-jin-gou

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hiahia12 @felix021 @ViolaPioggia @li-jin-gou