Gestion de mpm-event et php-fpm, avec les conf adequat par défaut

[gguillon]

No description provided.

[bpaquet]

Are you sure your PR does not break standard PHP5 install ?

[gguillon]

I've tested old behaviour ( = no mpm specified) it installs prefork
I've tested switching one to another (specifying event, prefork, event,
...) it toggles properly.
I've tested everything on one machine. I don't know how it'll behave on an
already installed apache. I'm confident il will behave well, but I'm would
like (you?) to test

On Mon, Oct 6, 2014 at 4:44 PM, Bertrand Paquet [email protected]
wrote:

Are you sure your PR does not break standard PHP5 install ?

—
Reply to this email directly or view it on GitHub
#12 (comment)
.

Gabriel Guillon
OCTO Technology
Expert
..........................................................
50, Avenue des Champs-Elysées
75008 Paris
Tél : (33) 1 58 56 10 00
Fax : (33) 1 58 56 10 01
GSM : (33) 6 67 35 33 58
http://www.octo.com/
http://blog.octo.com/
...........................................................
DevOps
http://blog.octo.com/devops-le-mouvement-qui-tend-a-%E2%80%9Cagilifier%E2%80%9D-votre-dsi/
? TTM + Stabilité = $€ !

[bpaquet]

Can not be merged as is

• the apache module disabled does not works with automatic purge of unused apache2 module
• comment in english
• do not specify action if action is the default
• do not remove package : do not install it (or it's not possible) ?
• do not disable a module : do not install / enable it ?
• service "php5-fpm" is declared twice. You should not do that

For a major modification like that, you should provide non regression test :)

[gguillon]

• Recipes is made to be able to switch between event and prefork (actually : to switch from prefork to event), without having to specify which apache module you want to enable (with modules_enabled), and just by specifying mpm=> event. With this is mind ( = not specifying modules_enabled), "Remove useless apache2 modules" does not work, as it relies on modules_enabled. Should I change this way of doing ?
• Ok for comments in english
• Ok for a default action
• That was for sanity : as mod_php5 is no longer used, I uninstall. I could leave it installed ...
• As said before, as I choose no to relies on modules_enables and choose to be able to switch, I have to be able to disable mod_php5. I could leave it enable, but it's dirty.
• WTF ?? : )

What form of regression test do you need ?
I'll test more on my local env, but maybe you need anything else ?

FYI : a web server was installed with prefork (it should'nt be). I just changed mpm in the role, and it switchs perfectly ! That was 15min ago :)

[gguillon]

Reg tests ok :
Installing a new slim lxc container with only apache, no specified mpm, defaul_vhost : it install prefork. Curl on vhost with a simple phpinfo.php is ok
Installing a new slim lxc container with only apache, mpm => 'prefork', defaul_vhost : it install prefork. Curl on vhost with a simple phpinfo.php is ok
Installing a new slim lxc container with only apache, mpm => 'event', defaul_vhost : it install event, start php-fpm. Curl on vhost with a simple phpinfo.php is ok
Installing a new slim lxc container with only apache, no specified mpm, defaul_vhost, then changing mpm to 'event' in role : uninstall prefork, install event. Curl ok.

Is there anything else I have to chnage ?