-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
simplified approach to ensuring Url type is returned from urlAssembly #308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for kitbag-router ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
pleek91
reviewed
Nov 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this looks good and I like the direction.
…d maybeRelativeUrl service to also export a function that joins the parts to create a Url.
pleek91
reviewed
Nov 14, 2024
pleek91
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In an attempt to simplify common use cases of
route.matches
, we discovered some functions that were returningstring
when they should be returningUrl
.In a previous approach, we put it on the developer to make sure the routes they built satisfy the Url type when assembled. However, we couldn't really test routes since routes might have dynamic params. Plus developers probably aren't super familiar with what it means for a route to be "assembled".
This PR takes a much simpler approach by just assembling the url, and then if the assembled url is NOT a valid Url type, it assumes the route must be relative and adds the forward slash.
This is no different from the query, how we automatically add the
?
, or hash how we always normalize the value to starting with#
. "Paths" (when assembled) are expected the start with/
, so if the developer omits it, we simply add it for them.as a side-quest this PR removes complexity from url parts (path, host, query, hash).
toString
and nohasValue
based on potentially stale values