remove match name from rejection route #304
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when testing the usability of
route.matches
, I came up with the following test caseYou'll notice how my
isRouteName
had to check that the name existed AND was not the rejection route. This feels wrong, and would not continue to work if additional rejection types were added.Instead, this PR removes the
name
property from the auto-generated route generated for a rejection type. My expectation is that this will have no effect on the router functionality but should make it easier for end users to validate a given route in matches.