Minor fixes or rejection route type guard and types in hook runner methods #261
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
while exploring the idea of "system" or "default" hooks to handle scroll position I found a couple bugs.
isRejectionRoute
out of createRouterReject, not used anywaysisRejectionRouteSymbol
defaults tofalse
when updating current route. We useObject.assign
to update current route. All non-rejection routes do not have this property. The initial current route is a rejection route (not found). So the property is there when we create the router and never gets unset. So every route appeared to be a rejection routeT extends Routes
on the hook runner methods but T was available from the parent function and wasn't being overridden.