Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve internal ValueContainer logics #94

Merged
merged 19 commits into from
Jul 19, 2024

Conversation

kitakkun
Copy link
Owner

@kitakkun kitakkun commented Jun 28, 2024

Related to #82, this PR refactors the code associated with ValueContainer.

@kitakkun kitakkun force-pushed the feature/embed_value_containers branch 3 times, most recently from 26637e4 to 1ae1ff2 Compare July 15, 2024 14:04
@kitakkun kitakkun force-pushed the feature/embed_value_containers branch from 1ae1ff2 to 78cdcc4 Compare July 16, 2024 08:17
@kitakkun kitakkun changed the title Remove ValueContainer DSL and Provide better way to configure ValueContainer classes Remove ValueContainer DSL and Improve internal clarity Jul 19, 2024
@kitakkun kitakkun changed the title Remove ValueContainer DSL and Improve internal clarity Improve internal ValueContainer logics Jul 19, 2024
@kitakkun kitakkun marked this pull request as ready for review July 19, 2024 10:53
@kitakkun kitakkun merged commit e040a93 into develop Jul 19, 2024
3 checks passed
@kitakkun kitakkun deleted the feature/embed_value_containers branch July 19, 2024 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant